Skip to content

feat(slicer): expand common machine profile settings - #2309

Merged
jpapiez merged 3 commits into
developmentfrom
dev/jpapiez/machine-profile-editor
Aug 31, 2026
Merged

feat(slicer): expand common machine profile settings#2309
jpapiez merged 3 commits into
developmentfrom
dev/jpapiez/machine-profile-editor

Conversation

@jpapiez

@jpapiez jpapiez commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • expose common machine hardware, build-volume, firmware, retraction, motion-limit, and start/end G-code settings through friendly metadata-driven controls
  • hydrate promoted MachineProfileDto values through one typed DTO-to-Orca adapter while preserving raw settings and untouched absent fields
  • normalize edited Orca wire shapes, clean up equivalent aliases only after explicit edits, preserve non-rectangular bed polygons, and support accurate dirty/reset behavior
  • expand the frontend worker profile contract and add focused adapter/modal coverage

Validation

  • React production build
  • 20 focused Vitest tests
  • TypeScript typecheck
  • ESLint
  • Git whitespace check

Review

Bishop, Hicks, and Vasquez approved commit 745992a0d5d8a8126f8354844ebe598090da4683 after two ordinary revision rounds.

Squad-Author: ripley

Closes #2307

Copilot AI added 3 commits August 31, 2026 09:51
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 302f6010-e0f7-4ffa-9138-504077f4282a
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 302f6010-e0f7-4ffa-9138-504077f4282a
@jpapiez jpapiez added the squad Squad triage inbox — Lead will assign to a member label Aug 31, 2026
@jpapiez

jpapiez commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Squad-Reviewer: bishop
Squad-Verdict: APPROVE
Squad-Head-SHA: 745992a

@jpapiez

jpapiez commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Squad-Reviewer: hicks
Squad-Verdict: APPROVE
Squad-Head-SHA: 745992a

@jpapiez

jpapiez commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Squad-Reviewer: vasquez
Squad-Verdict: APPROVE
Squad-Head-SHA: 745992a

@jpapiez

jpapiez commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

All three SHA-bound squad review records are now posted for 745992a0d5d8a8126f8354844ebe598090da4683; triggering final gate evaluation.

@jpapiez
jpapiez merged commit e94bb43 into development Aug 31, 2026
28 of 30 checks passed
@jpapiez
jpapiez deleted the dev/jpapiez/machine-profile-editor branch August 31, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad Squad triage inbox — Lead will assign to a member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task: expand common machine profile settings

2 participants