Remove the dead external-DB import module - #7
Merged
Conversation
spoolman/import_externaldb.py has never been reachable. Its only function, import_external_filaments, has no callers, no route, no poe task and no entry point -- searching the whole history for the name turns up only the commit that added it (05a4898), which brought it across while merging upstream PR Donkie#846 without the wiring that would have invoked it. So it has been dead since the day it landed, and no behaviour changes by deleting it. It is also no longer the way to do this. Upstream now exposes the external database through /external/filament, /external/material and /external/filament/search, and client_v2 creates filaments from those directly, so a server-side bulk importer is not the direction this is going. Verified: ruff clean, the app imports and registers its routes unchanged, and the unit tests pass. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request removes a dead, unreachable external-database bulk import module from the spoolman server package to reduce unused code and maintenance surface area.
Changes:
- Deleted
spoolman/import_externaldb.py, which contained an unusedimport_external_filamentsimporter and helper logic.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
spoolman/import_externaldb.py(116 lines). No behaviour change — the module was never reachable.Why it's dead
Its only function,
import_external_filaments, has:poetask or entry point inpyproject.toml,git log -S import_external_filaments --allreturns exactly one commit: 05a4898, the one that added it. It arrived while merging upstream PR Donkie#846 without the wiring that would have invoked it, so it has been dead since the day it landed.Why it shouldn't be revived
Upstream now covers this ground natively:
/external/filament,/external/materialand the new/external/filament/search, withclient_v2creating filaments from those endpoints directly. A server-side bulk importer isn't the direction external-DB support is heading, so this isn't a stub worth finishing.Validation
ruff check spoolman— clean.from spoolman.main import app→ 8 routes, unchanged).pytest tests— 26 passed.Context
Found while auditing what is genuinely fork-only versus upstream, in preparation for #5. Independent of #5 and #6 — this branches from
masterand touches a file neither of them modifies, so it can merge in any order.