Use async for sending over websockets #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation prior can heavily suffer from the slow subscriber issue where one client can possible slow down the other clients and even the filewriter.
NOTE:
I'm not sure if this change, sending over websockets async doesn't allow for new issues such as dead sockets that will never be closed or huge backlogs on one client.
Maybe a zeromq fan-out model where each client works on it's own queue is more reliable, this would also reduce locking issues when adding new subscribers, as each client will work on a different thread.
Using a ZeroMQ poller can also implement a heartbeat which currently is not implemented yet implied by the header