-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert User Management table header background color #3267
base: development
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that the table headers are no longer dark blue with white text. They now have a light background with black text as expected. Also, I noticed that the dropdown option is not properly aligned under the 'Role' section. I know this wasn't part of the PR, but I just wanted to point it out for future reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update works as expected. Restoring the original table header colors improves readability and maintains design consistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed PR. The code is neat and applies semantic class names effectively. The use of box-shadow adds depth to elements, and dark mode is well-implemented. The code works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yany960,
I have reviewed the PR and I have ran the application on my system by following the steps you mentioned. I have found that the application is showing the table headings row with the intended background color. So, I would agree to merge the implementation to the main.
Description
PR #2924 introduced a CSS change that altered the User Management table header background color to dark blue with white text. This PR reverts it back to the original light background with black text for better readability and consistency with the design.
Related PRS (if any):
This PR reverts the unintended style change from PR #2924.
Main changes explained:
How to test:
Screenshots or videos of changes:
Before:


After: