Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert User Management table header background color #3267

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

yany960
Copy link

@yany960 yany960 commented Mar 13, 2025

Description

PR #2924 introduced a CSS change that altered the User Management table header background color to dark blue with white text. This PR reverts it back to the original light background with black text for better readability and consistency with the design.

Related PRS (if any):

This PR reverts the unintended style change from PR #2924.

Main changes explained:

  • Reverted .table th styles in JobCCDashboard.css to restore the original background and text color.
  • Ensured consistency in the User Management table header appearance.

How to test:

  1. log in as an admin user.
  2. Go to User Management.
  3. Verify that the table headers are no longer dark blue with white text but have a light background with black text instead.

Screenshots or videos of changes:

Before:
image
After:
image

Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 73312cf
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67d332c1bb4f580008ec471c
😎 Deploy Preview https://deploy-preview-3267--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brn8 brn8 self-requested a review March 13, 2025 22:25
Copy link
Contributor

@brn8 brn8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the table headers are no longer dark blue with white text. They now have a light background with black text as expected. Also, I noticed that the dropdown option is not properly aligned under the 'Role' section. I know this wasn't part of the PR, but I just wanted to point it out for future reference.
image

@vikasreddynomula vikasreddynomula self-requested a review March 14, 2025 16:50
Copy link

@vikasreddynomula vikasreddynomula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-14 at 11 50 37 AM

The changes work as expected and the code looks good so approving this changes

Copy link

@puchakayalasaisaketh puchakayalasaisaketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the PR everything looks good

image

@yany960 yany960 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Mar 15, 2025
Copy link

@nikhilrouth nikhilrouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes in this PR and verified that the User Management table header background color has been correctly reverted to the original light background with black text for improved readability and consistency with the design.
It is working as expected so approving this PR 3267.

Screenshot 2025-03-14 at 9 58 43 PM

Copy link

@smohansatyaram smohansatyaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes function as intended, and the code appears to be in good shape. I approve these updates.
Screenshot 2025-03-14 220146

Copy link

@kkkaiaa kkkaiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR reviewed. The header color just show as described.
截屏2025-03-14 下午11 54 38

Copy link

@rishwa344 rishwa344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows the header as expected
Screenshot 2025-03-14 at 10 55 28 PM

@Akhilguntur2801
Copy link

I have tested this PR and the table header color and text color is changed as mentioned.
image

@SravyaKotra
Copy link

Update works as expected. Restoring the original table header colors improves readability and maintains design consistency.

@sidhu47h sidhu47h self-requested a review March 15, 2025 20:12
Copy link

@sidhu47h sidhu47h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are working as expected, the dark blue color is no more visible.

image

@HarideepValiveru
Copy link

Reviewed PR. The code is neat and applies semantic class names effectively. The use of box-shadow adds depth to elements, and dark mode is well-implemented. The code works as expected.

@HHHHHeloise
Copy link

Changed as expected. Well done!
Screenshot 2025-03-19 at 18 51 14

Copy link

@vamsikrishna1704 vamsikrishna1704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yany960,
I have reviewed the PR and I have ran the application on my system by following the steps you mentioned. I have found that the application is showing the table headings row with the intended background color. So, I would agree to merge the implementation to the main.
TableHeadingRowCSSSuccess

@humemah
Copy link

humemah commented Mar 23, 2025

Checked that the table headers in User Management now have a light background with black text instead of dark blue and white.
Made sure the table header looks the same across the UI.
484972623_1314593599793847_4444168791093107266_n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible Moved to Final Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.