Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rahul fix reports team page last table for small screens #3269

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

slidracoon72
Copy link
Contributor

@slidracoon72 slidracoon72 commented Mar 13, 2025

Description

Screenshot 2025-03-13 at 1 10 18 PM
Fixed the UI and layout of the last table in the Reports->Reports->Teams->Team Page

Related PRS (if any):

Not related

Main changes explained:

  • Improved the UI and layout of TeamReport.jsx for better responsiveness on smaller screens.
  • Enhanced TeamReportLogs.jsx and TeamsReportLogs.jsx to ensure compatibility with dark mode.
  • Updated relevant CSS files to optimize the last table's UI for smaller screens.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. check the before and after pictures and videos below to clearly see the updates made and understand how to test them effectively
  6. go to Reports->Reports->Teams->Team Page
  7. verify that the last table is responsive and displays correctly on smaller screens.
  8. verify this new feature works in dark mode

Screenshots or videos of changes:

BEFORE
PR 3269 - Before
Video Link:
https://github.com/user-attachments/assets/0e210e7b-549d-4c57-97d8-90abf387e69b

AFTER
PR 3269 - After
Video Link:
https://github.com/user-attachments/assets/1c0eda57-3cd6-4150-b247-3516ee30f314

Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 3bc9566
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67d33f217122de0009f121ba
😎 Deploy Preview https://deploy-preview-3269--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brn8 brn8 self-requested a review March 13, 2025 21:31
Copy link
Contributor

@brn8 brn8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the last table is responsive and displays correctly on smaller screens. However, I noticed that as the screen shrinks, a bottom scrollbar appears on the table. It might be worth adjusting the styling to ensure the table remains fully responsive without requiring horizontal scrolling.
image

@slidracoon72
Copy link
Contributor Author

slidracoon72 commented Mar 13, 2025

@brn8 This table is quite large and won't fit entirely on smaller screens, so horizontal scrolling is necessary.

@brn8
Copy link
Contributor

brn8 commented Mar 13, 2025

Got it. Thanks for the clarification! @slidracoon72

Copy link
Contributor

@Nayakar-Rohith Nayakar-Rohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and tested the fix for the reports team page layout on small screens. The table now displays correctly without any UI issues. The fix is working as expected. Approving this PR.
image

@vikasreddynomula vikasreddynomula self-requested a review March 14, 2025 16:44
Copy link

@vikasreddynomula vikasreddynomula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and tested the fix for the reports team page layout on small screens. The table now displays correctly without any UI issues, and the fix is functioning as expected. Approving this PR.

Screenshot 2025-03-14 at 11 42 17 AM

Copy link

@puchakayalasaisaketh puchakayalasaisaketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the PR and all the changes are working fine

image image

@Akhilguntur2801
Copy link

I have tested this PR, and the table renders correctly in both light and dark modes across various screen sizes.
image

Copy link

@nikhilrouth nikhilrouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes, and the UI and layout improvements for the last table in Reports → Reports → Teams → Team Page are working as expected. The updates ensure better responsiveness on smaller screens and function correctly in both dark and light modes.

However, I have observed that when shrinking the window, there is a noticeable gap between the table header and the filter above it (attached image below). They are not shrinking proportionally wrt each other. I think this might require further adjustment. I hope this comes under the scope of the fix? Let me know your thoughts.

working as expected
Screenshot 2025-03-15 at 1 58 00 PM

But Gap between the both rows after the shrink
Screenshot 2025-03-15 at 2 16 58 PM

Copy link

@vasavi-139 vasavi-139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as expected.

Screenshot 2025-03-17 212135
Screenshot 2025-03-17 212142

Copy link
Contributor

@abdel-lall abdel-lall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table is responsive as described, however, the input boxes appear jammed. Adding a little space between them would improve their appearance.

Screenshot 2025-03-23 005002

Copy link

@angad363 angad363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the PR by following the given instructions and checked the Team Page under Reports. The last table is now responsive across different screen sizes and displays correctly. Additionally, the updates are working as expected in dark mode.

Attaching a video for reference. Approving the PR.

PR.3269.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants