-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rahul fix reports team page last table for small screens #3269
base: development
Are you sure you want to change the base?
Rahul fix reports team page last table for small screens #3269
Conversation
…en responsiveness
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that the last table is responsive and displays correctly on smaller screens. However, I noticed that as the screen shrinks, a bottom scrollbar appears on the table. It might be worth adjusting the styling to ensure the table remains fully responsive without requiring horizontal scrolling.
@brn8 This table is quite large and won't fit entirely on smaller screens, so horizontal scrolling is necessary. |
Got it. Thanks for the clarification! @slidracoon72 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the changes, and the UI and layout improvements for the last table in Reports → Reports → Teams → Team Page are working as expected. The updates ensure better responsiveness on smaller screens and function correctly in both dark and light modes.
However, I have observed that when shrinking the window, there is a noticeable gap between the table header and the filter above it (attached image below). They are not shrinking proportionally wrt each other. I think this might require further adjustment. I hope this comes under the scope of the fix? Let me know your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the PR by following the given instructions and checked the Team Page under Reports. The last table is now responsive across different screen sizes and displays correctly. Additionally, the updates are working as expected in dark mode.
Attaching a video for reference. Approving the PR.
Description
Fixed the UI and layout of the last table in the Reports->Reports->Teams->Team Page
Related PRS (if any):
Not related
Main changes explained:
TeamReport.jsx
for better responsiveness on smaller screens.TeamReportLogs.jsx
andTeamsReportLogs.jsx
to ensure compatibility with dark mode.How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
BEFORE

Video Link:
https://github.com/user-attachments/assets/0e210e7b-549d-4c57-97d8-90abf387e69b
AFTER

Video Link:
https://github.com/user-attachments/assets/1c0eda57-3cd6-4150-b247-3516ee30f314