-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pavanswaroop-added-role-icons-reduced-header-searcheditor-tablecolumn-widths #3276
base: development
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code changes and followed the steps as mentioned. I checked into the current branch, ran npm install to install the necessary dependencies, and cleared the site data/cache. Then, I logged in as an admin user, navigated to the dashboard, clicked on "Other Links," and went to "User Management." I verified that the functions mentioned above worked as expected. Everything works fine, so I’m approving the PR. here is the screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code changes and followed the steps outlined in the PR description. I checked out the current branch, ran npm install to install the required dependencies, and cleared the site data/cache. After logging in as an admin user, I navigated to the dashboard, clicked on "Other Links," and went to "User Management." I verified that all the functions worked as expected. I also went through the code, and it meets the quality standards. Additionally, I checked the responsiveness, and everything works fine across various screen sizes, as shown in the attached video. Everything is functioning as expected, so I’m approving the PR. Here is the screenshot for reference.
PR.3276.-.4.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Reduce “Role” column and fix changing column widths on User Management page (WIP Pavan)
Admin Login → Other Links → User Management
Make the “Role” Column as narrow as possible. There are only a few roles, so we could turn those into icons instead of words, if needed to make it even narrower.
Related PRS (if any):
This frontend PR is not related to the any backend PR.
…
Main changes explained:
…
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
Screen.Recording.2025-03-14.at.9.05.07.PM.mov