Skip to content

Peterson_implement_improvements_in_404_page #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

peterson337
Copy link
Contributor

Description

This pull request has been opened to implement an error page after the user uses a link to redirect to a page that does not exist.

Related PRS (if any):

None

Main changes explained:

Ten components have been modified to implement the page of error.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Log in as any user.
  4. Go to a URL that does not exist, e.g., http://localhost:3000/project
  5. If the user is logged in, two links should appear on the error page: the first redirects to the dashboard, and the second also redirects to the same route but should open the modal for suggestions and development.
  6. If the user is not logged in, a link should appear on the error page that redirects to the login page.

Screenshots or videos of changes:

Peterson_implement_Default_Error_Page_to_be_created_and_redirected_to

Note:

None

@peterson337 peterson337 added the do not review Do not review or look at code without full context label Mar 18, 2025
Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit ac77e0c
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67ec1eee7486020008d38e43
😎 Deploy Preview https://deploy-preview-3286--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peterson337 peterson337 added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible do not review Do not review or look at code without full context and removed do not review Do not review or look at code without full context High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible labels Mar 19, 2025
@peterson337 peterson337 added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible and removed do not review Do not review or look at code without full context labels Apr 1, 2025
Copy link
Contributor

@vaibhavkoladiya vaibhavkoladiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected. I checked out the current branch, ran the PR locally after npm install, and tested both logged-in and logged-out states. When logged in, the error page correctly shows two links—one redirects to the dashboard, and the other opens the same route with the suggestions/development modal. When not logged in, the error page displays a link that properly redirects to the login page. Looks good to me—approved! ✅

Screen.Recording.2025-04-04.182506.mp4

Copy link

@rsripathi2906 rsripathi2906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the 404 error page implementation — everything works as expected.
Tested both logged-in and logged-out scenarios.
Links and modal behave correctly. Approving the PR.

Screen.Recording.2025-04-04.223938_1.mp4

Copy link

@sravankumarbodakonda sravankumarbodakonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the error page behavior based on user authentication. Logged-in users see two links—one to the dashboard and another that opens the suggestions/development modal. Unauthenticated users are correctly redirected to the login page. Everything is working as expected, i am approving the PR.
Screenshot 2025-04-09 at 12 03 54 AM
Screenshot 2025-04-09 at 12 03 41 AM
Screenshot 2025-04-09 at 12 03 25 AM

Copy link

@pavanputti pavanputti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the fix by checking out the current branch, running npm install, and starting the app locally. I logged in as a user, navigated to a nonexistent URL, and confirmed that the error page showed two links: one redirecting to the dashboard and another opening the suggestions modal while also redirecting to the dashboard. I then logged out, revisited the invalid URL, and verified that the error page displayed a single link redirecting to the login page.

Screen.Recording.2025-04-10.at.5.07.22.PM.mov
Screenshot 2025-04-10 at 5 11 57 PM

@KH07
Copy link
Contributor

KH07 commented Apr 11, 2025

It has been tested and functions as intended. I checked out to the current branch, did an npm install, started the app locally, and tried to access a page that did not exist. When not logged in, the error page shows a redirect link to the login page. When logged in, the error page shows two redirect links, both to the home page, and the second one opens a modal.
PR#3286 not logged in
PR#3286 logged in
PR#3286 logging in first link
PR#3286 logging in second link

Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything works as expected.

PR.vid.21.mp4

Copy link
Contributor

@JuliaHa0902 JuliaHa0902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked out the branch and followed the instructions to test the branch. It works as intended.
When not login:
Screenshot 2025-04-17 233440
When login
Screenshot 2025-04-17 233542
Screenshot 2025-04-17 233712
I clicked on the modal and the pop up showed
Screenshot 2025-04-17 233604
Just a suggestion, maybe we should remove the white part at the end of the page containing "Back to Top" button, or change the background to match the dark theme.
Screenshot 2025-04-17 233805

Copy link

@gopikalakshmia gopikalakshmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the branch.
Verified the "Not Found" page behavior before and after login.
Before login
image
After login (Home and User Suggestions pop-up available):
image
image

Works as intended .Approving the PR.

Copy link
Contributor

@Ram-blip Ram-blip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the PR and confirmed that the new error page correctly shows a single “Login” link for unauthenticated users, and for logged-in users it displays both a “Go to Dashboard” link and a “Send Feedback” link that opens the suggestions modal -everything navigates and behaves exactly as intended.

PR 3286 Screenshot 2025-05-29 at 5 25 27 PM

Copy link

@aayushshetty12 aayushshetty12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected.
When user is logged in, two links appear on the error page: the first redirects to the dashboard, and the second redirects to same dashboard with the modal for suggestions and development.
Screenshot 2025-07-12 033730
Screenshot 2025-07-12 033501

When user is not logged in, link appears on the error page that redirects to the login page.
Screenshot 2025-07-12 033857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.