-
-
Notifications
You must be signed in to change notification settings - Fork 56
Peterson_implement_improvements_in_404_page #3286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Peterson_implement_improvements_in_404_page #3286
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…e user's login state.
…e user's login state.
…e user's login state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected. I checked out the current branch, ran the PR locally after npm install, and tested both logged-in and logged-out states. When logged in, the error page correctly shows two links—one redirects to the dashboard, and the other opens the same route with the suggestions/development modal. When not logged in, the error page displays a link that properly redirects to the login page. Looks good to me—approved! ✅
Screen.Recording.2025-04-04.182506.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the 404 error page implementation — everything works as expected.
Tested both logged-in and logged-out scenarios.
Links and modal behave correctly. Approving the PR.
Screen.Recording.2025-04-04.223938_1.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the fix by checking out the current branch, running npm install, and starting the app locally. I logged in as a user, navigated to a nonexistent URL, and confirmed that the error page showed two links: one redirecting to the dashboard and another opening the suggestions modal while also redirecting to the dashboard. I then logged out, revisited the invalid URL, and verified that the error page displayed a single link redirecting to the login page.
Screen.Recording.2025-04-10.at.5.07.22.PM.mov

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the PR and everything works as expected.
PR.vid.21.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked out the branch and followed the instructions to test the branch. It works as intended.
When not login:
When login
I clicked on the modal and the pop up showed
Just a suggestion, maybe we should remove the white part at the end of the page containing "Back to Top" button, or change the background to match the dark theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the PR and confirmed that the new error page correctly shows a single “Login” link for unauthenticated users, and for logged-in users it displays both a “Go to Dashboard” link and a “Send Feedback” link that opens the suggestions modal -everything navigates and behaves exactly as intended.


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected.
When user is logged in, two links appear on the error page: the first redirects to the dashboard, and the second redirects to same dashboard with the modal for suggestions and development.
When user is not logged in, link appears on the error page that redirects to the login page.
Description
This pull request has been opened to implement an error page after the user uses a link to redirect to a page that does not exist.
Related PRS (if any):
None
Main changes explained:
Ten components have been modified to implement the page of error.
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
Note:
None