Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manoj Add edit ability and limit link type #2 #3287

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

Manoj99Q
Copy link
Contributor

Description

Added View Link and Edit buttons on both the task Assignee and Reviewer Dashboard
image

Related PRS (if any):

This is continuation of the Link Limit PR #3251
The same limit link check is applied when editing links.

Main changes explained:

  • Changed the disabled "Work Submitted and Awaiting Review" button which appears when the user submits their task with a link. I changed to a dropdown menu with the edit and view link buttons
  • On the reviewer side added two options in the existing "Ready for Review" Dropdown. - View and Edit Link

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. Follow this video for adding task to a user https://www.loom.com/share/8bc672c323b64955aac4bce46c3794aa?sid=8eb46081-a3a0-46c5-91e1-cc38c034c0c2
  5. After the task has be assigned to user, login to two accounts: both the reviewer ( a manager account) and the task assignee account. (Use two browser instances)
  6. Submit the task with a link
  7. Test the buttons to view and edit on both instances. (Might have to reload the other browser to get the reflected changes)
  8. Veirfy the buttons function as intended

Screenshots or videos of changes:

Screenshot from 2025-03-18 21-55-32
Screenshot from 2025-03-18 21-56-12

Copy link

netlify bot commented Mar 19, 2025

👷 Deploy request for highestgoodnetwork-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit dd52246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant