-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vinay: Let a user know through a popup that Permissions have been changed for them #3294
base: development
Are you sure you want to change the base?
Conversation
…ighestGoodNetworkApp into vinay/notify-user-new-permission
…n added" This reverts commit 0922fe7.
❌ Deploy Preview for highestgoodnetwork-dev failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code changes and followed the testing steps as outlined in the PR description. I checked out the "vinay/notify-user-new-permission" branch and logged in using an Owner account. I navigated to "Other Links" → "Permission Management" → "Manage User Permission," made changes to the permissions for two accounts (Angad Dev and Angad Test), and saved the updates. However, after logging into both of these accounts, the yellow popup notification about permission changes did not appear as demonstrated in the video. Additionally, I encountered an error message in the console (screenshot attached). Please review and address these issues before proceeding with the approval.
PR.3294.mp4
Additionally, I am not being able to edit user permissions using an administrator account. Only, reset to default button works in an admin account. |
Hi @angad363 |
…ighestGoodNetworkApp into vinay/notify-user-new-permission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to review this PR and I can't change the permissions for the testing account even though I am using an admin account. Am I missing something?
But, when I click submit on the changes, I can see the header on the account that has received the "changed" permissions.
So, it turns out that it works for Owner accounts and not Admin accounts.
As an owner, I was able to change permissions and a pop-up was alerted on the affected account.
Description
If an account changes permissions for another account, then when the account which has permissions edited, logs in, there should be a popup letting them know that permissions have been edited in this account. Only should happen for the first time the user logs into account after permissions were edited.
Related PRS (if any):
This frontend PR is related to the #1278 backend PR.
…
Main changes explained:
…
How to test:
Screenshots or videos of changes:
video1858768607.mp4
Note:
Include the information the reviewers need to know.