Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI changes to the edit task feature on WBS list page #3300

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ShraddhaShahari
Copy link
Contributor

Description

image
image

Related PRS (if any):
This frontend PR which is not related to the any backend PR.

Main changes explained:

Previously, the layout of "Edit Task" form was different, this update ensures it remains stable and visually consistent same as "Add Task" form.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. login as Admin/Owner user
  5. Other Links>Projects>WBS Icon>Choose a WBS>Edit Task
  6. verify that the formatting should look same as when you Add Task: Admin/Owner login>Other Links>Projects>WBS Icon>Choose a WBS>Add Task
  7. Please refer screenshot below to verify above changes

Screenshots or videos of changes:

image

Note:

Include the information the reviewers need to know.

@ShraddhaShahari ShraddhaShahari added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Mar 21, 2025
Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit ba72831
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67ddede21fdcb300082a0425
😎 Deploy Preview https://deploy-preview-3300--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@nikhilrouth nikhilrouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed and tested this PR and found a few inconsistencies and discrepancies:

UI Discrepancies in Edit Task vs. Add Task:

  1. Status Row: Labels are misaligned compared to Add Task.

  2. Hours Row: Labels are bold in Edit Task but normal in Add Task, and there is a spacing difference.

  3. Text Fields (Why this Task is Important, Design Intent, Endstate): Edit Task includes colons (:) at the end of statements, while Add Task does not.

  4. Date Formatting: Dates in Edit Task (2025-03-21T07:00:00.00) are not formatted properly.

Please refer below

PR 3300

@one-community
Copy link
Member

I have reviewed and tested this PR and found a few inconsistencies and discrepancies:

UI Discrepancies in Edit Task vs. Add Task:

  1. Status Row: Labels are misaligned compared to Add Task.
  2. Hours Row: Labels are bold in Edit Task but normal in Add Task, and there is a spacing difference.
  3. Text Fields (Why this Task is Important, Design Intent, Endstate): Edit Task includes colons (:) at the end of statements, while Add Task does not.
  4. Date Formatting: Dates in Edit Task (2025-03-21T07:00:00.00) are not formatted properly.

Please refer below

PR 3300

Great review!

@one-community
Copy link
Member

I have reviewed and tested this PR and found a few inconsistencies and discrepancies:
UI Discrepancies in Edit Task vs. Add Task:

  1. Status Row: Labels are misaligned compared to Add Task.
  2. Hours Row: Labels are bold in Edit Task but normal in Add Task, and there is a spacing difference.
  3. Text Fields (Why this Task is Important, Design Intent, Endstate): Edit Task includes colons (:) at the end of statements, while Add Task does not.
  4. Date Formatting: Dates in Edit Task (2025-03-21T07:00:00.00) are not formatted properly.

Please refer below
PR 3300

Great review!

My feedback clarifications based on this: https://www.loom.com/share/2b7ba1847eec433b8cf8ea447e5802ad?sid=82c461a6-31f8-4429-a8b1-05703ae1573a

@ShraddhaShahari ShraddhaShahari added do not review Do not review or look at code without full context and removed High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible labels Mar 22, 2025
@ShraddhaShahari
Copy link
Contributor Author

I will start doing all the suggested changes, and will raise the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not review Do not review or look at code without full context
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants