-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added UI changes to the edit task feature on WBS list page #3300
base: development
Are you sure you want to change the base?
Added UI changes to the edit task feature on WBS list page #3300
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed and tested this PR and found a few inconsistencies and discrepancies:
UI Discrepancies in Edit Task vs. Add Task:
-
Status Row: Labels are misaligned compared to Add Task.
-
Hours Row: Labels are bold in Edit Task but normal in Add Task, and there is a spacing difference.
-
Text Fields (Why this Task is Important, Design Intent, Endstate): Edit Task includes colons (:) at the end of statements, while Add Task does not.
-
Date Formatting: Dates in Edit Task (2025-03-21T07:00:00.00) are not formatted properly.
Please refer below
Great review! |
My feedback clarifications based on this: https://www.loom.com/share/2b7ba1847eec433b8cf8ea447e5802ad?sid=82c461a6-31f8-4429-a8b1-05703ae1573a |
I will start doing all the suggested changes, and will raise the PR. |
Description
Related PRS (if any):
This frontend PR which is not related to the any backend PR.
Main changes explained:
Previously, the layout of "Edit Task" form was different, this update ensures it remains stable and visually consistent same as "Add Task" form.
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
Note:
Include the information the reviewers need to know.