Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular version by default, fixes multiple layouts bugs #20

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

trilowy
Copy link
Collaborator

@trilowy trilowy commented Aug 12, 2024

What changes:

  • gitignore to have kanata exe directly into the project (particularly useful to dev)
  • modular version by default (we might want to add a tag 1.0.0 on the previous version?)
  • replaced 102d by <, easier to ready what this key does
  • altgr layer upgraded with the latest 1dk layout version (^@ inversion)
  • fix azerty symbols layer for ~ and `, they were dead keys
  • let altgr on the numrow to allow azerty to do those symbols in dead key mod
  • nav et symbols layers didn’t work very well with other layouts, as letters move and numbers are sometime on shift, etc, so I made an alias file by layout and all is variablised on the different mods (there is a PC/Mac version for each layout as shortcuts and some special characters might not be the same)
  • I reverse back Enter and Esc to match the images but we can change it back easily if we prefer that way

@trilowy
Copy link
Collaborator Author

trilowy commented Aug 12, 2024

Might fix #17

@trilowy
Copy link
Collaborator Author

trilowy commented Aug 12, 2024

#13 done for Bépo

@trilowy
Copy link
Collaborator Author

trilowy commented Aug 12, 2024

#11 also done but it might lack the proper documentation with images

Copy link
Collaborator

@fabi1cazenave fabi1cazenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much saner, thanks a lot for your contribution!

I’ve left a couple nitpicks/suggestions, we can merge if you approve them.

@fabi1cazenave
Copy link
Collaborator

replaced 102d by <, easier to [read] what this key does

I’m surprised I didn’t see that. Maybe it’s a recent feature ?

Copy link
Collaborator

@fabi1cazenave fabi1cazenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftovers: s/hold/held (duh)

@trilowy trilowy force-pushed the fixes branch 2 times, most recently from 23dab07 to f619954 Compare August 13, 2024 17:18
@fabi1cazenave fabi1cazenave merged commit 948bfea into OneDeadKey:main Aug 13, 2024
@trilowy trilowy deleted the fixes branch August 13, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants