Skip to content

Ogc 2853 agency new UI#2324

Open
BreathingFlesh wants to merge 24 commits intomasterfrom
ogc-2853-agency-new-ui
Open

Ogc 2853 agency new UI#2324
BreathingFlesh wants to merge 24 commits intomasterfrom
ogc-2853-agency-new-ui

Conversation

@BreathingFlesh
Copy link
Contributor

@BreathingFlesh BreathingFlesh commented Feb 3, 2026

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Agency: New UI

TYPE: Feature
LINK: OGC-2853

Checklist

  • I have performed a self-review of my code
  • I considered adding a reviewer
  • I have added an upgrade hint such as data migration commands to be run
  • I have updated the PO files
  • I have tested my code thoroughly by hand
    • I have tested styling changes/features on different browsers
    • I have tested javascript changes/features on different browsers
  • I have added tests for my changes/features

@linear
Copy link

linear bot commented Feb 3, 2026

@Tschuppi81
Copy link
Contributor

Tschuppi81 commented Feb 3, 2026

When adding a new organization, the send/save button is at the bottom
image

  • add user
image
  • form change url, also misses breadcrumbs
image

@Tschuppi81
Copy link
Contributor

Tschuppi81 commented Feb 3, 2026

More views with send/save button at the bottom

  • organization move
Screenshot from 2026-02-03 17-00-42
  • organization sort
Screenshot from 2026-02-03 17-00-57
  • organization change url
Screenshot from 2026-02-03 17-01-11
  • organization create pdf
Screenshot from 2026-02-03 17-01-28
  • user profile
image

@Tschuppi81
Copy link
Contributor

Personally, I think the whole person card should be 'clickable' not just the title/name of the card
Screenshot from 2026-02-03 17-14-12

@Tschuppi81
Copy link
Contributor

Survey url change does not work, e.g. http://localhost:8080/onegov_agency/lu/survey/test/change-url
image

@codecov
Copy link

codecov bot commented Feb 4, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2628 1 2627 17
View the top 1 failed test(s) by shortest run time
tests/onegov/landsgemeinde/test_browser.py::test_ticker
Stack Traces | 39.1s run time
browser = <tests.shared.browser.InjectedBrowserExtension.spawn.<locals>.LeechedExtendedBrowser object at 0x7f19a04d5e50>
assembly = <onegov.landsgemeinde.models.assembly.Assembly object at 0x7f199df2d7d0>

    def test_ticker(browser: WebsocketBrowser, assembly: Assembly) -> None:
        app = browser.wsgi_server.app
        app.session().add(assembly)
        commit()
    
        browser.visit('.../landsgemeinde/2023-05-07/ticker')
        assert browser.websocket_server_url in browser.html
    
        # refresh
        assembly = app.session().query(Assembly).one()
        assembly.overview = 'Lorem ipsum'
        assembly.agenda_items[0].title = 'Adipiscing elit'
        commit()
    
        # ... wrong date
        app.send_websocket({
            'event': 'refresh',
            'assembly': '2023-05-06'
        })
        assert 'Lorem ipsum' not in browser.html
        assert 'Adipiscing elit' not in browser.html
    
        # ... correct date
        app.send_websocket({
            'event': 'refresh',
            'assembly': '2023-05-07'
        })
>       assert 'Lorem ipsum' in browser.html
E       AssertionError: assert 'Lorem ipsum' in ''
E        +  where '' = <tests.shared.browser.InjectedBrowserExtension.spawn.<locals>.LeechedExtendedBrowser object at 0x7f19a04d5e50>.html

.../onegov/landsgemeinde/test_browser.py:39: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants