V4 to v5 upgrade will migrate app ID for wrapper SDKs#2244
Merged
Conversation
b3d9c40 to
5287fef
Compare
jkasten2
approved these changes
Jan 30, 2025
jinliu9508
approved these changes
Jan 30, 2025
Contributor
jinliu9508
left a comment
There was a problem hiding this comment.
LGTM!
Also verified that Player Model is using the same key to store a legacy app ID.
* In wrappers, after an app upgrades from player to user model, if the app is not opened yet and a notification is received, there was no app ID detected and init returns early. * Now, check for the cached app ID from v4 and use that to continue the init process. This mimics what should happen when using the native SDK directly. * The reason this is an issue on wrappers is because when an app upgrades, the Application `onCreate` is called, without needing to open the app. However, in wrappers, the `onCreate` does not set app ID.
5287fef to
f572b8d
Compare
Contributor
Author
|
Just rebased the branch, no changes. Looks like a maybe-flaky test added recently is failing the unit tests: https://github.com/OneSignal/OneSignal-Android-SDK/actions/runs/13064783338/job/36455552170?pr=2244 |
Merged
This was referenced Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
(Resolves an issue that only affects wrappers) When migrating from v4 to v5, check for a cached app ID from v4 if none are available on v5.
Details
Motivation
initWithContextreturns early.onCreateis automatically called, without needing to open the app. In native SDK clients, their OneSignal initialization code will run here and populate the app ID, setup the user, etc. However, in wrappers, clients don't modify the native code so theonCreatedoes not set app ID.Scope
Testing
Unit testing
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is