Identity verification beta 3 #2283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix subscription/IAM not updated after upgrading from 5.2.0-beta or between 5.1.9 to 5.1.27
release 5.1.30
Fix: ANR caused by model.add(), model.initializeFromJson(), or modelstore.load()
Release 5.1.31
…tions that have no valid JWT
Identity Verification beta release # Conflicts: # Examples/OneSignalDemo/app/build.gradle # OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/OneSignalUtils.kt # OneSignalSDK/settings.gradle
Commit just contains the upgrades themselves, a follow up commit will includes changes required to address their build requirements.
* namespace is now always required * Some gradle.properties values were completely dropped in APG 8 * Publish release access changed to avoid build error, more changes are need to actually publish.
Since Gradle / AGP 8 upgrade the example doesn't work for Huawei builds, however this uncovered we were not correctly omitting it for all tasks. We will fix Huawei in the example project not building in follow up commit.
The top level gradle project needs a Java / Kotlin module, otherwise it skipped publishing an .aar file. While there is no code, projects consuming this SDK look for it. * Maybe we can omit the .aar on in the future for this top level project but keeping it working the same for now. Built SDK with Java 17 and tested publishing with a staging build with: * Java 11 * Gradle 7.3.3 * APG 7.2.2 * Android 5 & 14 Emulator WARNING: It is still recommended building with Java 17 instead of 21 when publishing, as those on older version of R8 will get this build error: * Cannot invoke "String.length()" because "<parameter1>" is null * See https://stackoverflow.com/q/77788162
…gnal/OneSignal-Android-SDK into identity_verification_beta
jkasten2
reviewed
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ AND DELETE THIS SECTION BEFORE SUBMITTING PR
Description
One Line Summary
REQUIRED - Very short description that summaries the changes in this PR.
Details
Motivation
REQUIRED - Why is this code change being made? Or what is the goal of this PR? Examples: Fixes a specific bug, provides additional logging to debug future issues, feature to allow X.
Scope
RECOMMEND - OPTIONAL - What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default.
OPTIONAL - Other
OPTIONAL - Feel free to add any other sections or sub-sections that can explain your PR better.
Testing
Unit testing
OPTIONAL - Explain unit tests added, if not clear in the code.
Manual testing
RECOMMEND - OPTIONAL - Explain what scenarios were tested and the environment.
Example: Tested opening a notification while the app was foregrounded, app build with Android Studio 2020.3 with a fresh install of the OneSignal example app on a Pixel 6 with Android 12.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is