test: increase code coverage across various modules #1409

sherwinski · 2025-11-18T18:52:47Z

1 Line Summary

Increases testing code coverage for certain modules that are labelled as low-coverage (≤50%) by vitest.

Details

Increases tests for the following:

SessionManager

Adds new test files for the following:

Bell
Badge
Launcher
Button
Dialog
Message
Bell
LoginManager
TagManager
PromptsManager
helpers
IDManager
PermissionManager

Before

 Test Files  40 passed (40)
      Tests  359 passed (359)
   Start at  10:26:36
   Duration  6.37s (transform 12.24s, setup 8.80s, collect 16.51s, tests 8.05s, environment 14.64s, prepare 3.47s)
 % Coverage report from v8
=============================== Coverage summary ===============================
Statements   : 63.18% ( 3572/5653 )
Branches     : 50.01% ( 1476/2951 )
Functions    : 70.55% ( 865/1226 )
Lines        : 63.37% ( 3461/5461 )
================================================================================

After

 Test Files  52 passed (52)
      Tests  393 passed (393)
   Start at  05:14:55
   Duration  32.94s (transform 8.41s, setup 17.21s, collect 18.03s, tests 6.97s, environment 33.19s, prepare 5.19s)
 % Coverage report from v8
=============================== Coverage summary ===============================
Statements   : 67.52% ( 3817/5653 )
Branches     : 54.86% ( 1619/2951 )
Functions    : 75.44% ( 925/1226 )
Lines        : 67.69% ( 3697/5461 )
================================================================================

Systems Affected

WebSDK
Backend
Dashboard

Validation

Tests

Info

Checklist

All the automated tests pass or I explained why that is not possible
I have personally tested this on my machine or explained why that is not possible
I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

Don't use default export
New interfaces are in model files

Functions:

Don't use default export
All function signatures have return types
Helpers should not access any data but rather be given the data to operate on.

Typescript:

No Typescript warnings
Avoid silencing null/undefined warnings with the exclamation point

Other:

Iteration: refrain from using elem of array syntax. Prefer forEach or use map
Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets

This change is

- `_upsertSession` paths: no user (no SW notify), user + SW supported (calls `_notifySWToUpsertSession` + installs listeners once), no SW (sets `_onSessionSent` on `_UserCreate`, emits `SESSION_STARTED`). - `_notifySWToUpsertSession` builds proper payload and posts to worker messenger. - `_handleOnFocus`/`_handleOnBlur` wait for `LoginManager._switchingUsersPromise` and log on errors (augment existing switching-user tests).

- Constructor respects enable false early-return; defaults for size/position/theme; installs hooks/updates state when enabled. - State transitions when `_subscribed`/`_unsubscribed`/`_blocked` flags change trigger message/display logic guards.

Tests for: - triggers events - unsubscribed + not optedOut → calls register flow - toggles dialog path and hides message - resets handling flag

- `_show`/`_hide` set `_shown` and resolve promises - visibility classes toggle

…te` clears activation

… `_hide` idempotency

…oken path; transfer subscription path

…ent hooks install once; native vs slidedown gating

…f non-empty; returns `{}` and warns when no diff; stores remote/local tags mutate internal state

… error on timeout; `enforceAppId`/`enforceAlias` throw and pass when expected

…ike uniqueness

- Maps Notification permission states - guards for unavailable API in environment

src/shared/managers/PermissionManager.test.ts

src/page/managers/PromptsManager.test.ts

src/page/managers/LoginManager.test.ts

src/shared/managers/PermissionManager.test.ts

src/page/bell/Bell.test.ts

src/page/bell/Dialog.test.ts

src/shared/context/helpers.test.ts

src/shared/managers/sessionManager/SessionManager.test.ts

sherwinski added 13 commits November 17, 2025 22:29

test(Badge): _updateCount increments/decrements and clears when <=0

c59cf33

test(Button): add case for _onClick concurrency guard

ca58f1f

Tests for: - triggers events - unsubscribed + not optedOut → calls register flow - toggles dialog path and hides message - resets handling flag

test(Dialog): add _show/_hide tests

595a93c

- `_show`/`_hide` set `_shown` and resolve promises - visibility classes toggle

test(Launcher): _activateIfInactive activates only once; `_inactiva…

54b79c1

…te` clears activation

test(Message): _display shows message with timeout then hides; test…

497336b

… `_hide` idempotency

test(LoginManager): _switchingUsersPromise sequencing; login with t…

a352438

…oken path; transfer subscription path

test(PromptsManager): _shouldForceSlidedownOverNative decisions; ev…

35e993e

…ent hooks install once; native vs slidedown gating

test(TagManager): _sendTags calls OneSignal.User.addTags when dif…

c9ab2cc

…f non-empty; returns `{}` and warns when no diff; stores remote/local tags mutate internal state

test(helpers): timeoutPromise resolves and times out, returns raced…

7b6eb3e

… error on timeout; `enforceAppId`/`enforceAlias` throw and pass when expected

test(IDManager): _createLocalId uses LOCAL_PREFIX and produces UUID-l…

907acf8

…ike uniqueness

test(PermissionManager): add tests for core functionality

631d230

- Maps Notification permission states - guards for unavailable API in environment

sherwinski requested a review from fadi-george November 18, 2025 18:52