Enforce static lifetime for instrumentation functions

[cstyles]

We only ever provide static string slices to these functions. We can enforce that in the function signatures and save ourselves an allocation.

---

This change is 

[lilymara-onesignal]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @cstyles)

---

src/experiment.rs line 38 at r1 (raw file):

}

async fn instrument_control<F, T>(name: &'static str, future: F) -> T

Can we do impl Into<Cow<'static, str>> to allow for the possibility of dynamic names?

[cstyles]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lilymara-onesignal)

---

src/experiment.rs line 38 at r1 (raw file):

Previously, lilymara-onesignal (Lily Mara) wrote…

Can we do impl Into<Cow<'static, str>> to allow for the possibility of dynamic names?

We can, although we only ever call these functions with the name field which has to be a &'static str per the constructor:

thesis/src/experiment.rs

Line 26 in 1a60048

pub fn new(name: &'static str) -> Self {

Would you like me to update the constructor as well?

[lilymara-onesignal]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @cstyles)

---

src/experiment.rs line 38 at r1 (raw file):

Previously, cstyles (Collin Styles) wrote…

We can, although we only ever call these functions with the name field which has to be a &'static str per the constructor:

thesis/src/experiment.rs

Line 26 in 1a60048

pub fn new(name: &'static str) -> Self {

Would you like me to update the constructor as well?

Ahh ok, maybe then this is not necessary. Let's leave as &'static str