fix: share one 80-char cap for image and table asset filenames - #242
Merged
Conversation
Unify the post-#236 image context truncate with table header naming so cosmetic asset stems use a single MAX_ASSET_FILE_NAME_CHARS constant. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
60while table header naming used a separate_MAX_TABLE_NAME_CHARS = 80.MAX_ASSET_FILE_NAME_CHARS = 80infile_utilsand use it for markdown image naming, deferred image rename, and table header sanitization.Test plan
last_contextstill succeeds (noFile name too long)sanitize_table_name_from_headerMade with Cursor