Skip to content

Conversation

@jfckm
Copy link

@jfckm jfckm commented Mar 18, 2022

Signed-off-by: Jan Musial [email protected]


This change is Reviewable

@pep8speaks
Copy link

pep8speaks commented Mar 18, 2022

Hello @jfckm! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-18 11:05:10 UTC

@jfckm jfckm force-pushed the mark-security-tests branch from d4c1571 to 82ca8b0 Compare March 18, 2022 08:46
@jfckm
Copy link
Author

jfckm commented Mar 18, 2022

@CAS-Linux-Jenkins retest this please

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #672 (a34936f) into master (4fc3f8f) will decrease coverage by 0.39%.
The diff coverage is n/a.

❗ Current head a34936f differs from pull request most recent head 447f9a2. Consider uploading reports for the commit 447f9a2 to get more accurate results

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   63.87%   63.48%   -0.40%     
==========================================
  Files          89       89              
  Lines        9974     9974              
==========================================
- Hits         6371     6332      -39     
- Misses       3603     3642      +39     
Impacted Files Coverage Δ
src/mngt/ocf_mngt_core.c 60.03% <0.00%> (-1.92%) ⬇️
src/metadata/metadata_superblock.c 73.22% <0.00%> (-1.58%) ⬇️
src/metadata/metadata.c 68.64% <0.00%> (-1.45%) ⬇️
src/mngt/ocf_mngt_cache.c 61.61% <0.00%> (-1.12%) ⬇️

robertbaldyga
robertbaldyga previously approved these changes Mar 18, 2022
security: security objectives coverage, do not run by default
long: long, do not run by default
addopts = --ignore=tests/security -m "not long"
addopts = -m "not long and not security"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so now no security test will run in CI? this would disable a couple tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants