cleanup req->error setting #762
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocentSzachista
requested review from
KlaudiaJ,
arutk,
kmajzero and
robertbaldyga
DocentSzachista
force-pushed
the
cleanup-req
branch
from
8135cc4 to
77dcea7
Compare
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
==========================================
- Coverage 71.39% 71.37% -0.03%
==========================================
Files 90 90
Lines 10162 10151 -11
==========================================
- Hits 7255 7245 -10
+ Misses 2907 2906 -1
|
mmichal10
reviewed
Nov 21, 2022
src/engine/engine_bf.c
Outdated
| } | ||
|
|
||
| if (req->error) | ||
| if (req->error.counter) |
There was a problem hiding this comment.
Variables of type env_atomic should be accessed using env_atomic_read()
Signed-off-by: Damian Raczkowski <[email protected]>
DocentSzachista
force-pushed
the
cleanup-req
branch
from
77dcea7 to
ad3fd2f
Compare
robertbaldyga
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Damian Raczkowski [email protected]