Skip to content

aggregate_spatial: Clarified that the output geometries are unchang… - #548

Merged
m-mohr merged 4 commits into
draftfrom
aggregate-spatial-geometries
Aug 8, 2025
Merged

aggregate_spatial: Clarified that the output geometries are unchang…#548
m-mohr merged 4 commits into
draftfrom
aggregate-spatial-geometries

Conversation

@m-mohr

@m-mohr m-mohr commented Jul 17, 2025

Copy link
Copy Markdown
Member

aggregate_spatial: Clarified that the output geometries are unchanged compared to the input geometries.

Closes #499

@clausmichele

Copy link
Copy Markdown
Member

Is is implicit that the implementation should accept data and geometries with different projections?

@m-mohr

m-mohr commented Jul 17, 2025

Copy link
Copy Markdown
Member Author

@clausmichele Yeah, currently it is. Shall we make this explicit?

@clausmichele

Copy link
Copy Markdown
Member

Yes @m-mohr, I think it would be better to mention it explicitly.

@m-mohr

m-mohr commented Jul 18, 2025

Copy link
Copy Markdown
Member Author

I guess we'd need to mention this in the data parameter, maybe like this?

A raster data cube with at least two spatial dimensions.\n\nThe data cube implicitly gets restricted to the bounds of the geometries as if filter_spatial() would have been used with the same values for the corresponding parameters immediately before this process. If the CRS of the raster data cube doesn't match the CRS of the geometries, the raster data will be reprojected to the CRS of the geometries.

@clausmichele

Copy link
Copy Markdown
Member

I guess we'd need to mention this in the data parameter, maybe like this?

A raster data cube with at least two spatial dimensions.\n\nThe data cube implicitly gets restricted to the bounds of the geometries as if filter_spatial() would have been used with the same values for the corresponding parameters immediately before this process. If the CRS of the raster data cube doesn't match the CRS of the geometries, the raster data will be reprojected to the CRS of the geometries.

Perfect thanks.

@m-mohr

m-mohr commented Jul 21, 2025

Copy link
Copy Markdown
Member Author

Thanks, updated.

Comment thread aggregate_spatial.json Outdated
Comment thread aggregate_spatial.json Outdated
@m-mohr
m-mohr requested a review from soxofaan August 7, 2025 19:23
@m-mohr
m-mohr force-pushed the aggregate-spatial-geometries branch from 2c41766 to 0315fb5 Compare August 7, 2025 19:45
@m-mohr
m-mohr merged commit 7974ff2 into draft Aug 8, 2025
2 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Next processes release Aug 8, 2025
@m-mohr
m-mohr deleted the aggregate-spatial-geometries branch August 8, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

aggregate_spatial: crs of data and geometry mismatch undefined

4 participants