-
Notifications
You must be signed in to change notification settings - Fork 27
chore: add aspect and slope definitions #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dsamaey
wants to merge
12
commits into
Open-EO:master
Choose a base branch
from
dsamaey:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−0
Open
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5f40d85
chore: add aspect and slope definitions
dsamaey 9c0c64e
Update CHANGELOG.md
dsamaey a173b35
fix: add placeholder tests for aspect and slope
dsamaey ea9a68e
Update .words
dsamaey 63b9610
Update aspect.json
dsamaey fa41dc5
Update slope.json
dsamaey a1c3f6c
removed _aspect and _slope from .words
dsamaey 353b930
Update aspect.json
dsamaey c435448
Update slope.json
dsamaey 61c8ffe
Update aspect.json5
dsamaey b08dbde
Update slope.json5
dsamaey d196ef8
Apply suggestions from code review
m-mohr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "id": "aspect", | ||
| "summary": "The aspect of a terrain surface", | ||
| "description": "Compute the aspect (in radians, from due North) of elevation data.", | ||
| "categories": [ | ||
| "cubes", | ||
| "math" | ||
| ], | ||
| "experimental": true, | ||
| "parameters": [ | ||
| { | ||
| "name": "parameters", | ||
| "description": "A data cube with n bands containing elevation data", | ||
| "schema": { | ||
| "type": "object", | ||
| "subtype": "datacube" | ||
| } | ||
| } | ||
| ], | ||
| "returns": { | ||
| "description": "A data cube with n bands named after the n bands in the input data cube, suffixed with ``'aspect'``. Each band contains the computed aspect values (in radians, from due North). In case the surface is flat, the NaN value is used (since there is no direction of the gradient).", | ||
|
m-mohr marked this conversation as resolved.
Outdated
|
||
| "schema": { | ||
| "type": "object", | ||
| "subtype": "datacube" | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "id": "slope", | ||
| "summary": "The slope of a terrain surface", | ||
| "description": "Compute the slope (in radians, relative to the horizontal plane) of elevation data.", | ||
| "categories": [ | ||
| "cubes", | ||
| "math" | ||
| ], | ||
| "experimental": true, | ||
| "parameters": [ | ||
| { | ||
| "name": "parameters", | ||
| "description": "A data cube with n bands containing elevation data", | ||
| "schema": { | ||
| "type": "object", | ||
| "subtype": "datacube" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably define the required dimension types here (x,y,bands?), potentially also in the return value. See other processes for details. |
||
| } | ||
| } | ||
| ], | ||
| "returns": { | ||
| "description": "A data cube with n bands named after the n bands in the input data cube, suffixed with ``'_slope'``. Each band contains the computed slope values (in radians, relative to the horizontal plane).", | ||
|
m-mohr marked this conversation as resolved.
Outdated
|
||
| "schema": { | ||
| "type": "object", | ||
| "subtype": "datacube" | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "id": "aspect", | ||
| "level": "L3", | ||
| "experimental": true, | ||
| "tests": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "id": "slope", | ||
| "level": "L3", | ||
| "experimental": true, | ||
| "tests": [] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably define the required dimension types here (x,y,bands?), potentially also in the return value. See other processes for details.