Fix Sherpa local ASR state sync#523
Merged
H-Chris233 merged 4 commits intoMay 23, 2026
Merged
Conversation
PR Reviewer Guide 🔍(Review updated until commit 6d6510f)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit cd9696d |
|
Persistent review updated to latest commit 75a5082 |
|
Persistent review updated to latest commit 072b7a1 |
072b7a1 to
6d6510f
Compare
|
Persistent review updated to latest commit 6d6510f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
摘要
tokenizer/目录校验和downloadedBytes统计。beta解决设置页重构冲突:旧 Settings.tsx 不再进入本 PR,新版 settings/ProvidersSection.tsx 中已包含sherpa-onnx-local的本地 provider 识别逻辑。验证
git diff --check upstream/beta...HEAD✅cargo check --manifest-path openless-all/app/src-tauri/Cargo.toml✅npm run build✅cargo test --manifest-path openless-all/app/src-tauri/Cargo.toml sherpa --lib -- --nocapture✅cargo test --manifest-path openless-all/app/src-tauri/Cargo.toml persist_settings --lib -- --nocapture✅PR Type
Bug fix, Enhancement, Tests
Description
Sync active ASR provider during saves.
Validate Sherpa archives and tokenizer directories.
Track downloaded bytes in catalog snapshots.
Refresh Overview and delete availability state.
Diagram Walkthrough
File Walkthrough
7 files
Add path validation and download byte trackingVerify archives and refine progress reportingUse validated paths in catalog snapshotsSync active ASR provider while savingRestore active ASR provider on startupAllow delete when bytes already existRefresh credentials on provider changes2 files
Add vault sync helpers for ASRExtend Sherpa IPC types and signatures