-
Notifications
You must be signed in to change notification settings - Fork 169
[frontend/backend] Migrate CVE to Vulnerabilities #4272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job, and you have done well mapping the CVE API with the underlying, renamed components (Vulnerability*).
However do mind some now unused classes, e.g. src/test/java/io/openaev/utils/fixtures/composers/CveComposer.java; do have a look around if there aren't others and delete them as needed.
All tests pass locally, however you may notice in the CI the code is currently tripping the formatting guards.
For the backend, you may run mvn spotless:apply
For the frontend, it's yarn lint --fix
Once you have fixed this and pushed the new formatting, the CI should pass. Request a review from a team member to get the PR approved, and then merge when convenient so that you may go forward with the next chunks.
Also seek advice with @RomuDeuxfois if you feel stuck.
2ba91c7 to
6b8a056
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/current #4272 +/- ##
=====================================================
+ Coverage 49.04% 49.60% +0.56%
- Complexity 3497 3645 +148
=====================================================
Files 875 881 +6
Lines 26045 26595 +550
Branches 1939 2011 +72
=====================================================
+ Hits 12773 13192 +419
- Misses 12505 12627 +122
- Partials 767 776 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openaev-api/src/main/java/io/openaev/migration/V4_44__Rename_cves_table_to_vulnerabilities.java
Show resolved
Hide resolved
638525c to
03f57d3
Compare
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
cced1d1 to
3ce7584
Compare
openaev-api/src/main/java/io/openaev/rest/vulnerability/VulnerabilityApi.java
Outdated
Show resolved
Hide resolved
3dc942c to
00c4edf
Compare
198e69a to
124d2c2
Compare
|
Code: OK |
Proposed changes
Testing Instructions
Related issues
Checklist
Further comments
Issue separated in 4 chunk, brainstorm in link
https://www.notion.so/filigran/Migrate-CVE-to-Vulnerabilities-2868fce17f2a808fbeb9cc673795c5c6?source=copy_link