Skip to content

Conversation

@GaetanSantucci
Copy link
Member

@GaetanSantucci GaetanSantucci commented Oct 16, 2025

Proposed changes

  • Rename CVE to vulnerability including table
  • Update CveApi to map on vulnerabilty service to maintain contracts

Testing Instructions

  1. in the front, check that all labels and translations are in vulnerabilities and are no longer cves
  2. test cveApi and vulnerabilityApi

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Issue separated in 4 chunk, brainstorm in link
https://www.notion.so/filigran/Migrate-CVE-to-Vulnerabilities-2868fce17f2a808fbeb9cc673795c5c6?source=copy_link

@GaetanSantucci GaetanSantucci added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team labels Oct 16, 2025
Copy link
Member

@antoinemzs antoinemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, and you have done well mapping the CVE API with the underlying, renamed components (Vulnerability*).

However do mind some now unused classes, e.g. src/test/java/io/openaev/utils/fixtures/composers/CveComposer.java; do have a look around if there aren't others and delete them as needed.

All tests pass locally, however you may notice in the CI the code is currently tripping the formatting guards.

For the backend, you may run mvn spotless:apply

Image

For the frontend, it's yarn lint --fix

Image

Once you have fixed this and pushed the new formatting, the CI should pass. Request a review from a team member to get the PR approved, and then merge when convenient so that you may go forward with the next chunks.

Also seek advice with @RomuDeuxfois if you feel stuck.

@GaetanSantucci GaetanSantucci marked this pull request as ready for review October 17, 2025 06:54
@GaetanSantucci GaetanSantucci force-pushed the fix-migrationCVE branch 2 times, most recently from 2ba91c7 to 6b8a056 Compare October 20, 2025 09:48
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.60%. Comparing base (3101281) to head (32316c7).
⚠️ Report is 5 commits behind head on release/current.

Files with missing lines Patch % Lines
...st/vulnerability/service/VulnerabilityService.java 77.77% 17 Missing and 3 partials ⚠️
...a/io/openaev/utils/mapper/VulnerabilityMapper.java 74.24% 10 Missing and 7 partials ⚠️
...c/main/java/io/openaev/utils/mapper/CveMapper.java 79.16% 2 Missing and 3 partials ⚠️
...o/openaev/rest/vulnerability/VulnerabilityApi.java 86.66% 2 Missing ⚠️
...-api/src/main/java/io/openaev/rest/cve/CveApi.java 87.50% 1 Missing ⚠️
.../openaev/service/stix/SecurityCoverageService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #4272      +/-   ##
=====================================================
+ Coverage              49.04%   49.60%   +0.56%     
- Complexity              3497     3645     +148     
=====================================================
  Files                    875      881       +6     
  Lines                  26045    26595     +550     
  Branches                1939     2011      +72     
=====================================================
+ Hits                   12773    13192     +419     
- Misses                 12505    12627     +122     
- Partials                 767      776       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@savacano28 savacano28 self-requested a review October 20, 2025 10:33
@savacano28 savacano28 changed the title [all] Migrate CVE to Vulnerabilities #3738 [frontend/backend] Migrate CVE to Vulnerabilities (#3738) Oct 20, 2025
@savacano28
Copy link
Contributor

savacano28 commented Oct 23, 2025

Code: OK
Tests:
CRUD vulnerability: OK
Outputparser/Findings: Ok
Nuclei injector insert contract: OK
Nvist collector: Ok

@GaetanSantucci GaetanSantucci changed the title [frontend/backend] Migrate CVE to Vulnerabilities (#3738) [frontend/backend] Migrate CVE to Vulnerabilities Oct 23, 2025
@GaetanSantucci GaetanSantucci merged commit 0b4806e into release/current Oct 23, 2025
10 checks passed
@GaetanSantucci GaetanSantucci deleted the fix-migrationCVE branch October 23, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug use for describing something not working as expected filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants