Skip to content

Conversation

WonderCsabo
Copy link
Contributor

@WonderCsabo WonderCsabo commented Sep 2, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l

@wing328
Copy link
Member

wing328 commented Sep 2, 2025

thanks for the pr

can you review the build failure when you've time?

@WonderCsabo
Copy link
Contributor Author

https://github.com/OpenAPITools/openapi-generator/actions/runs/17399819940/job/49390120768

For me it seems the echo server is not started. These are the logs for the Run echo server step:

Run git clone https://github.com/wing328/http-echo-server -b openapi-generator-test-server
  git clone https://github.com/wing328/http-echo-server -b openapi-generator-test-server
  (cd http-echo-server && npm install && npm start &)
  shell: /usr/bin/bash -e {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.16-8/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.16-8/x64
    GRADLE_BUILD_ACTION_SETUP_COMPLETED: true
    GRADLE_BUILD_ACTION_CACHE_RESTORED: true
    DEVELOCITY_INJECTION_INIT_SCRIPT_NAME: gradle-actions.inject-develocity.init.gradle
    DEVELOCITY_AUTO_INJECTION_CUSTOM_VALUE: gradle-actions
    GITHUB_DEPENDENCY_GRAPH_ENABLED: false
Cloning into 'http-echo-server'...

https://github.com/OpenAPITools/openapi-generator/actions/runs/17399819930/

All of the jobs have this error:

Gradle requires JVM 17 or later to run. Your build is currently configured to use JVM 11.

I updated Gradle to 9.0.0. Should i downgrade it for now?

@WonderCsabo WonderCsabo force-pushed the kotlin-update-versions branch from 80b7c22 to 77b4878 Compare September 2, 2025 12:02
@wing328
Copy link
Member

wing328 commented Sep 2, 2025

I updated Gradle to 9.0.0. Should i downgrade it for now?

good question. gradle 8.x active support was ended like a month ago: https://endoflife.date/gradle

shall we take this opportunity to only support gradle 9.x moving forward?

i think it's a good idea but let see if the Kotlin technical committee members have a different opinion on this.

@WonderCsabo
Copy link
Contributor Author

I also vote for supporting Gradle 9.x . However we need to change the CI to run JVM 17, i will need a little help with that.

@wing328
Copy link
Member

wing328 commented Sep 2, 2025

https://github.com/OpenAPITools/openapi-generator/actions/runs/17402841036/workflow?pr=21866#L79

you will need to change that to 17

ref: .github/workflows/samples-kotlin-client.yaml

@WonderCsabo WonderCsabo force-pushed the kotlin-update-versions branch 2 times, most recently from fb3e249 to e0aa4aa Compare September 3, 2025 08:19
@WonderCsabo
Copy link
Contributor Author

@wing328 i changed it to Java 17, it works. Thanks!

I still have an issue with the echo server. Can you check it pls?

Also there is an unrelated build error on one of the Circle CI runs.

@WonderCsabo
Copy link
Contributor Author

@wing328 can you check these if you have time? ⬆️

@wing328
Copy link
Member

wing328 commented Sep 12, 2025

here is the feedback from Gradle team:

I discussed it a bit more within the team and this is what we propose:
We think you should continue to support Gradle 8 for some time. You can still upgrade your build to Gradle 9, though, then you'd need to add tests for Gradle 8 support and possibly make sure you compile to target Java 8. For Gradle plugins written in Kotlin using Gradle 9 to build a plugin that runs on Gradle 8 is problematic, since the Kotlin versions are not backward compatible. So we would avoid doing that.

ref: https://openapi-generator.slack.com/archives/CLSB0U0R5/p1757653266058709?thread_ts=1755862642.667769&cid=CLSB0U0R5

@WonderCsabo WonderCsabo force-pushed the kotlin-update-versions branch 2 times, most recently from bfc9f7b to 2705b6f Compare September 15, 2025 08:18
@WonderCsabo WonderCsabo force-pushed the kotlin-update-versions branch from 2705b6f to dbcf05d Compare September 15, 2025 09:31
@wing328
Copy link
Member

wing328 commented Sep 15, 2025

circle ci failure not related to this change

@wing328
Copy link
Member

wing328 commented Sep 15, 2025

thanks for the PR 🙏

let's give it a try

@wing328 wing328 merged commit 5c04b75 into OpenAPITools:master Sep 15, 2025
65 of 66 checks passed
@WonderCsabo WonderCsabo deleted the kotlin-update-versions branch September 15, 2025 19:01
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants