-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[kotlin-client] update Kotlin and libraries versions #21866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kotlin-client] update Kotlin and libraries versions #21866
Conversation
thanks for the pr can you review the build failure when you've time? |
https://github.com/OpenAPITools/openapi-generator/actions/runs/17399819940/job/49390120768 For me it seems the echo server is not started. These are the logs for the
https://github.com/OpenAPITools/openapi-generator/actions/runs/17399819930/ All of the jobs have this error:
I updated Gradle to 9.0.0. Should i downgrade it for now? |
80b7c22
to
77b4878
Compare
good question. gradle 8.x active support was ended like a month ago: https://endoflife.date/gradle shall we take this opportunity to only support gradle 9.x moving forward? i think it's a good idea but let see if the Kotlin technical committee members have a different opinion on this. |
I also vote for supporting Gradle 9.x . However we need to change the CI to run JVM 17, i will need a little help with that. |
https://github.com/OpenAPITools/openapi-generator/actions/runs/17402841036/workflow?pr=21866#L79 you will need to change that to 17 ref: .github/workflows/samples-kotlin-client.yaml |
fb3e249
to
e0aa4aa
Compare
@wing328 i changed it to Java 17, it works. Thanks! I still have an issue with the echo server. Can you check it pls? Also there is an unrelated build error on one of the Circle CI runs. |
@wing328 can you check these if you have time? ⬆️ |
here is the feedback from Gradle team:
|
modules/openapi-generator/src/main/resources/kotlin-client/README.mustache
Outdated
Show resolved
Hide resolved
bfc9f7b
to
2705b6f
Compare
2705b6f
to
dbcf05d
Compare
circle ci failure not related to this change |
thanks for the PR 🙏 let's give it a try |
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)"fixes #123"
present in the PR description)@dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l