Skip to content

Fix crashes when compiled with ASan #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hpoggie wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix crashes when compiled with ASan #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9acc5c8
Add ignore for asan
hpoggie Jan 15, 2019
db64ddc
Fix strncpy copying a string onto itself
hpoggie Jan 15, 2019
13e3082
Add Makefile.local.asan
hpoggie Jan 23, 2019
9cffc4a
Fix asan ignore list not being used
hpoggie Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Makefile.local.asan
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Compiles with ASan (https://github.com/google/sanitizers/wiki/AddressSanitizer)
# How to use:
# cp Makefile.local.asan Makefile.local && make
CC=clang
CFLAGS+=-fsanitize=address
CFLAGS+=-g
CFLAGS+=-fsanitize-blacklist=asan_ignore.txt
1 change: 1 addition & 0 deletions asan_ignore.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fun:VM_Call
4 changes: 3 additions & 1 deletion code/client/cl_cgame.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,9 @@ intptr_t CL_CgameSystemCalls( intptr_t *args ) {
Com_Memcpy( VMA(1), VMA(2), args[3] );
return 0;
case CG_STRNCPY:
strncpy( VMA(1), VMA(2), args[3] );
if (VMA(1) != VMA(2)) {
strncpy( VMA(1), VMA(2), args[3] );
}
return args[1];
case CG_SIN:
return FloatAsInt( sin( VMF(1) ) );
Expand Down