refactor: improve container monitor initialization and signal handling#136
Merged
ComixHe merged 1 commit intoOpenAtom-Linyaps:masterfrom Jan 5, 2026
Merged
refactor: improve container monitor initialization and signal handling#136ComixHe merged 1 commit intoOpenAtom-Linyaps:masterfrom
ComixHe merged 1 commit intoOpenAtom-Linyaps:masterfrom
Conversation
Collaborator
ComixHe
commented
Jan 5, 2026
ComixHe
commented
- Move container_monitor creation after container status update to RUNNING
- Refactor enable_signal_forwarding to return bool instead of accepting host_tty
- Enhance child process reaping with waitpid(-1, WNOHANG) loop
- Move host_tty creation logic into enable_io_forwarding for better cohesion
- Add fallback to get default terminal size from /dev/tty when size is zero
- Move container_monitor creation after container status update to RUNNING - Refactor enable_signal_forwarding to return bool instead of accepting host_tty - Enhance child process reaping with waitpid(-1, WNOHANG) loop - Move host_tty creation logic into enable_io_forwarding for better cohesion - Add fallback to get default terminal size from /dev/tty when size is zero Signed-off-by: ComixHe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.