fix: ensure IO forwarding completes when child exits early#142
Merged
ComixHe merged 1 commit intoOpenAtom-Linyaps:masterfrom Feb 3, 2026
Merged
fix: ensure IO forwarding completes when child exits early#142ComixHe merged 1 commit intoOpenAtom-Linyaps:masterfrom
ComixHe merged 1 commit intoOpenAtom-Linyaps:masterfrom
Conversation
Remove early return in enable_signal_forwarding() when no child process is detected. This ensures that IO forwarding continues to work even if the child process exits before signal forwarding is fully set up, preventing potential data loss. Signed-off-by: ComixHe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove early return in enable_signal_forwarding() when no child process is detected. This ensures that IO forwarding continues to work even if the child process exits before signal forwarding is fully set up, preventing potential data loss.