Skip to content

fix: mount host font configuration directories #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Iceyer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: mount host font configuration directories #1602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libs/oci-cfg-generators/src/linglong/oci-cfg-generators/container_cfg_builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,8 +477,10 @@ ContainerCfgBuilder &ContainerCfgBuilder::bindHostStatics() noexcept
{
std::vector<std::filesystem::path> statics{
"/etc/machine-id",
"/etc/fonts",
Comment on lines 479 to +480
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and consistency, please consider keeping the list of paths sorted alphabetically within their respective groups (e.g., /etc, /usr/share). The /usr/share paths are already sorted alphabetically, and applying the same convention to the /etc paths would improve readability as this list grows.

        "/etc/fonts",
        "/etc/machine-id",

// FIXME: support for host /etc/ssl, ref https://github.com/p11-glue/p11-kit
"/usr/lib/locale",
"/usr/share/fontconfig",
"/usr/share/fonts",
"/usr/share/icons",
"/usr/share/themes",
Expand Down
Loading