Skip to content

fix(filelock): release replaced lock resources on move assignment - #1935

Open
89799969 wants to merge 1 commit into
OpenAtom-Linyaps:masterfrom
89799969:codex/filelock-move-assignment
Open

fix(filelock): release replaced lock resources on move assignment#1935
89799969 wants to merge 1 commit into
OpenAtom-Linyaps:masterfrom
89799969:codex/filelock-move-assignment

Conversation

@89799969

@89799969 89799969 commented Sep 7, 2026

Copy link
Copy Markdown

Closes #1934

Summary

  • Release the destination lock resources before move assignment.
  • Reuse the noexcept cleanup path from both the destructor and move assignment.
  • Verify that the replaced lock path can be reopened immediately.

Validation

  • git diff --check

Signed-off-by: halaxy <63827956+89799969@users.noreply.github.com>
@deepin-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 89799969

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown
Collaborator

Welcome @89799969! It looks like this is your first PR to OpenAtom-Linyaps/linyaps 🎉

@deepin-ci-robot

Copy link
Copy Markdown
Collaborator

Hi @89799969. Thanks for your PR.

I'm waiting for a OpenAtom-Linyaps member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

89799969 commented Sep 7, 2026

Copy link
Copy Markdown
Author

Hi @dengbo11, could you please take a quick look and, if the patch is reasonable to test, add /ok-to-test so the remaining CI jobs can run?

This is a focused move-assignment resource cleanup fix for #1934. The license check, cppcheck, and pre-commit checks are already passing. Thanks!

@89799969
89799969 marked this pull request as ready for review September 8, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(filelock): release replaced lock resources on move assignment

2 participants