fix: allow bulk upload of images and improve error handling #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeschen
requested changes
Apr 25, 2025
Contributor
mikeschen
left a comment
mikeschen
left a comment
There was a problem hiding this comment.
Looks pretty good, there are two TypeScript errors:
/home/runner/work/open-tacos/open-tacos/src/js/hooks/usePhotoUploader.tsx:127:33: Trailing spaces not allowed. (no-trailing-spaces)
/home/runner/work/open-tacos/open-tacos/src/js/hooks/usePhotoUploader.tsx:163:35: Functions that return promises must be async. (@typescript-eslint/promise-function-async)
Once these are fixed I will check and approve, nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1266 by:
The changes allow users to drag and drop multiple images at once, with proper error handling and feedback for each file.