WIP: C Exports, C# Exports and Fixing CI Workflows #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo: Set default targets as Windows Updated: Script to run `wine` on host, for faster testing.
This is 'technically correct', and also fixes Wine.
* This is needed for architectures with a separate instruction and data cache. * In x86 and x64 these are unified, so this is not necessary. * If it turns out this is needed for e.g. x64 emulation on ARM64, it may be re-enabled one day.
Sewer56
changed the title
…hich lib to load.
…into add-c-exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on:
So please address that first, as changes from those PRs will show as a diff here otherwise.
[This branch still needs some cleanup regarding string formatting, and error handling]
This PR adds C bindings (both dynamic and static libraries), as well as auto generated C# bindings.
This includes tests against the C bindings, the C# bindings are untested. The bindings only cover the core API right now, now RPC. They're not yet perfect with regards to error handling, am in a rush, unfortunately.
Aside from that, some workflow changes have been made:
You may want to make changes to these workflows.
To suit your personal preferences, also because they currently reference the actions I made for my Reloaded libraries, in the time since I've started working with Rust (7-8 months ago).
The C dynamic libraries are built with
into-x86-from-x64out of the box.They are approx 220kB for i686 and 300kB for x86_64.
For most people that's probably 'good enough', but not for me.
In the future I plan to:
goblinwith own minimal PE parser that gets only info I need.iced-x86with manual assembly.I hope to achieve sub <50kB size.
I'll throw the ones that don't affect the public API as future PRs. After that, I'll probably hard fork the project to strip the functionality I don't need.