Update Utilties.CloneObject and normalise line endings. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2nd change wasn't really intentional, but from the web editor of GitHub.
|
what's the reason behind this change? |
|
The main reason was that BinaryFormatter was apparently completed removed in the latest .NET version, so I had to replace it with reflection instead (I also could've done binary format to JSON and then do that, but I find this approach better anyway). |
|
Thanks, I'll take a look at any potential implications - if it's alright I might commit the change without the line ending changes to preserve the git blame if that's ok |
|
Yeah, that's OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2nd change wasn't really intentional, but from the web editor of GitHub.