Adds TCP broker supporting zero-delimited frames #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds an implementation of a TCP-broker that observes the zero-byte frame delimiter of COBS-encoded Cyphal/Serial frames. This commit addresses OpenCyphal#300 Signed-off-by: Hannes Weisbach <[email protected]> Signed-off-by: Hannes Weisbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds an implementation of a TCP-broker that observes the zero-byte frame delimiter of COBS-encoded Cyphal/Serial frames.
This commit addresses #300
I randomly stumbled upon #300 by accident. We at Neosat have a simple broker that does observe zero-delimited framing.
I cleaned it up a bit, added comments, etc.
I'm open to comments/change requests.
Open questions:
I'm not exactly sure where to put the file in the source tree.
How much/what tests would you require?
Edit: I forgot to bump the version number 😬 Would that be a minor or patch bump?