-
Notifications
You must be signed in to change notification settings - Fork 3
refactor: major refactor of dc6 package #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gucio321
wants to merge
10
commits into
OpenDiablo2:main
Choose a base branch
from
gucio321:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c8d4885
refactoring: refactor of dc6 package
gucio321 6620b3a
bugfix: decode frame; display correct image
gucio321 e4408d8
readme: fix misspelling
gucio321 4fe0e45
cmd/dc6-view: fix typo in pkg name
gucio321 3b2328d
pkg/doc: fix package description
gucio321 06e738f
dc6: predeclare error variable returned by loadFrames
gucio321 1672a06
fix go.mod and tests:
gucio321 afcbb72
setup linter; fix lint errors
gucio321 b443712
pkg/giuwidget: add sliders
gucio321 ff3fb71
cmd/dc6-convert: change option name dc6lib -> dc6
gucio321 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| [](https://goreportcard.com/report/github.com/OpenDiablo2/dc6) | ||
| [](https://pkg.go.dev/mod/github.com/OpenDiablo2/dc6) | ||
|
|
||
| ## Description | ||
|
|
||
| This is a module used to decoding and encoding Diablo II animation files (DC6) | ||
|
|
||
| ## Documentation | ||
|
|
||
| a documentation describing this fileformat can be found here: | ||
| - [MarkKoz/DC6.ksy](https://gist.github.com/MarkKoz/874052801d7eddd1bb4a9b69cd1e9ac8) [and here](./docs/dc6.ksy) | ||
| - [The Phrozen Keep: DC6 Format](https://d2mods.info/forum/viewtopic.php?t=724#p148076) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
| package pkg | ||
| // Package docs contains a documentation files (unused in real module) | ||
| package docs | ||
|
|
||
| // Header represents the file header of a DC6 file. | ||
| type Header struct { | ||
| // DC6Header represents the file header of a DC6 file. | ||
| // this structure is unused in this module and is only a documentation | ||
| type DC6Header struct { | ||
| Termination []byte `struct:"[4]byte"` | ||
| Version int32 `struct:"int32"` | ||
| Flags uint32 `struct:"uint32"` | ||
| Encoding uint32 `struct:"uint32"` | ||
| Termination []byte `struct:"[4]byte"` | ||
| Directions int32 `struct:"int32"` | ||
| FramesPerDirection int32 `struct:"int32"` | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| module github.com/gravestench/dc6 | ||
| module github.com/OpenDiablo2/dc6 | ||
|
|
||
| go 1.16 | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.