Cubic interpolation for SeaState and HydroDyn #3007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently only supports 3D and 4D interpolation. Can add 2D interpolation in the future if needed. * Supports interpolation of scalar data, 3-by-1 vector data, and 6-by-1 vector data. * Will use C1 continuous cubic interpolation if possible. Toward grid boundary, quadratic interpolation is used. Linear interpolation is used if only two grid points are present. * If one of the grid dimensions has only 1 grid point, this dimension is effectively ignored. * Each dimension can be indicated as either periodic or not. * Periodic dimensions will always use cubic interpolation because the grid is effectively infinite in this direction. * For non-periodic dimensions, a query point will be snapped back to the grid boundary if out of bound. A warning will be given at the first occurrence. * Note that for periodic dimensions, the subroutines assume the first and last grid points are NOT duplicates of each other.
luwang00
added
Type: Enhancement
Module: HydroDyn
Module: NWTC Lib
Module: SeaState
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This PR adds a new set of generic 3D and 4D uniform grid interpolation tools under nwtc-library. The new interpolation tools:
The new grid interpolation tools are developed with SeaState and HydroDyn in mind, which previously relied on linear interpolation. The present cubic interpolation is expected to be significantly more accurate even on coarser grids and with larger time steps, saving memory. The new interpolation tools are also generic and can potentially be used by other modules in the future.
There are merge conflicts with
devdue to some recent changes by @andrew-platt that need to be resolved.This PR will also create merge conflicts with
dev-tc.Impacted areas of the software
nwtc-library, seastate, hydrodyn, moordyn
Test results, if applicable
With the switch from linear to cubic interpolation, some r-test cases involving SeaState and HydroDyn now have slightly different results. These were updated.
To-Dos:
dev