MoorDyn: increase number of attachment points possible for bodies/anchors/points #3034
+135
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These parameters are used both in the code and in the registry for sizing arrays.
Some FAST.Farm simulations were running into issues with too many lines attached to anchors or bodies.
RyanDavies19
suggested changes
Oct 14, 2025
There was a problem hiding this comment.
@andrew-platt thanks for putting this together. There is a call of Point%nAttached <10 in MoorDyn_Point.f90 that should be changed.
It might also be good to add a check of il against MD_MaxFailLines to avoid array overrun in this loop:
openfast/modules/moordyn/src/MoorDyn.f90
Line 2025 in 0284731
|
Thanks Andy! I didn't realize that something like MD_MaxBdAtch could be available within subroutines like Body_AddPoint without extra parameters being passed in. This will be great. |
- Body_AddRod - Body_AddPoint - Rod_AddLine - Check nLinesToDetach <= MD_MaxFailLines
RyanDavies19
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge... if it works
Feature or improvement description
Using MoorDyn was artificially limited to 30 attachments to bodies, which was an issue for very large shared mooring FAST.Farm simulations. This PR parameterizes these limits in the registry so that it is easy to change later (this PR also bumps up the limits for now).
Related issue, if one exists
#3022
Impacted areas of the software
Very large MoorDyn models with many interconnects only.
Additional supporting information
This is not the ideal way to deal with this. A better solution is to set the limits on these arrays while reading in the model. However the memory cost with doing it this way is not large compared to the complexity the code could end up with.
Test results, if applicable
No test results should change.