fix: Use PANEL_TYPE=internal for Flip KB/DS to fix touch rotation in gamescope - #15
Open
hijae wants to merge 1 commit into
Open
fix: Use PANEL_TYPE=internal for Flip KB/DS to fix touch rotation in gamescope#15hijae wants to merge 1 commit into
hijae wants to merge 1 commit into
Conversation
…gamescope PANEL_TYPE=external breaks the I2C-touch to internal-connector heuristic in wlserver_touch_associate_connector(), silently skipping touch rotation. Verified fixed on real Flip KB hardware; Flip DS uses the same touch controller but was not independently tested.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Continuing work to fix touch input on AyaNeo Flip KB. The touch calibration issue was fixed upstream in systemd (systemd/systemd#43501, merged). This PR addresses the next issue in the same effort: touch is rotated 90 degrees relative to the display in gamescope (Game Mode). Desktop sessions are unaffected.
Fix
device-quirkscurrently groups Flip KB and Flip DS with AIR/AIR Pro/AIR Plus/SLIDE underPANEL_TYPE=external. Splitting them into their ownPANEL_TYPE=internalblocks fixes the touch rotation. AIR/AIR Pro/AIR Plus/SLIDE are left untouched — no hardware available to verify whether they're affected the same way.Testing