Skip to content

HID: usbhid: skip interrupt IN polling for devices with no input reports #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ghoul4500 wants to merge 1 commit into from
Closed

HID: usbhid: skip interrupt IN polling for devices with no input reports #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion drivers/hid/usbhid/hid-core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,14 @@ static int usbhid_open(struct hid_device *hid)

set_bit(HID_OPENED, &usbhid->iofl);

if (hid->quirks & HID_QUIRK_ALWAYS_POLL) {
/*
* ALWAYS_POLL devices are already polled from usbhid_start(), and a
* device with no input reports has nothing to send on the interrupt
* IN endpoint. In some cases polling is harmful: on the ASUS ROG
* N-Key keyboards it makes the sibling interface drop keypresses.
*/
if ((hid->quirks & HID_QUIRK_ALWAYS_POLL) ||
list_empty(&hid->report_enum[HID_INPUT_REPORT].report_list)) {
res = 0;
goto Done;
}
Expand Down