Repository navigation
revert: restore standalone automation skills (OSS-14957) - #863
Conversation
This reverts commit f79208b to restore standalone automation skills and their scripts. Co-authored-by: openhands <openhands@all-hands.dev>
Preserve the newly added comment-cleanup plugin while retaining plugin bundle path support needed by its catalog entry. Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
This review was posted by an AI agent (OpenHands).
Reviewed the revert at head 3337a38 against main, with the repository guidance in AGENTS.md applied. The change is squarely in this repository's scope (it owns the public registry of skills, plugins, and automation catalog bundles), so the review proceeded to the technical pass.
Verified in the workspace at this exact head:
uv run pytest tests/— 1520 passed, 23 skipped, matching CI's run on this commit.npm run build:automations— passes; regeneratedbundle-index.js/catalog-index.jsare byte-identical to the committed generated files, and all 9 generated bundles were verified byte-equal to their manifestfilessources.python scripts/sync_extensions.py --check— passes with only the same non-blocking coverage warnings that exist onmain(plugins/github-comment-cleanup,plugins/issue-duplicate-checker), which are intentional per the PR description.- All 24 catalog manifests validate against
automations/catalog.schema.json; every bundle source path referenced by the manifests exists (symlinks intoskills/github/scripts/resolve, andskills/github/itself is untouched by this diff). - The core regression is real and fixed:
skills/github-issue-triage/scripts/worker.pyis absent onmainand present after the revert. Installing the five standalone skills (github-issue-triage,github-issue-to-pr,github-pr-reviewer,github-agents-md-maintainer,github-repo-monitor) viaopenhands.sdk.skills.install_skillinto a temp directory yields complete bundle files, andimport workersucceeds from the installedscripts/directory. - The end state of
catalog.schema.jsonandscripts/build-automation-catalog.mjsis byte-identical tomain, soplugins/bundle sources remain valid for the newergithub-comment-cleanupautomation, whose plugin, tests, and marketplace entries are preserved unchanged. Head contains all ofmain(no commits behind). - No stale
plugins/<name>setup references remain in the restored skill guides, and the slack-channel-monitor script carries no trailing whitespace, matching the PR notes.
The two intentional deviations from a pure revert (removed WORKSPACE_BASE re-set in test_automation_llm_provenance.py; empty __file__ in test_slack_channel_monitor.py) are covered by the passing suite and are not material. The rollout caveat for plugin-spec automations fetching removed plugins/<name> paths from moving main, and the npm-packaging caveat for symlinked helpers, are already disclosed in the PR notes for the maintainer to weigh; nothing further to add.
No material issues found.
✅ APPROVED
|
🚀 Released in v0.37.0. |
HUMAN:
Reverting changes as per the PR #812
AGENT:
Why
PR #812 removed task guidance and runtime scripts from 11 standalone automation skills. Installing
github-issue-triage, for example, gave an agent a plugin-spec setup guide but no worker or helpers. Restore the standalone skills while we verify the intended packaging contract.Summary
skills/<name>/.plugins/bundle path support needed by the newergithub-comment-cleanupautomation on main, and keep its plugin-only installation tests. Remove one restored trailing whitespace character in the Slack channel monitor skill.Issue Number
OSS-14957 - Revert plugin-spec transition due to skill breakage
Related historical GitHub issue: #815 (closed,
ready-for-dev) tracked the migration in the original PR. This PR reverses that implementation; it does not claim to complete the issue's original acceptance criteria.How to Test
From the extensions repo root, I ran:
An inline Python check validated every automation catalog manifest against
automations/catalog.schema.json, compared bundle sources toautomations/bundle-index.js, installed and imported five standalone skills withopenhands.sdk.skills.install_skill(github-issue-triage,github-issue-to-pr,github-pr-reviewer,github-agents-md-maintainer,github-repo-monitor), and built a triage tarball with the software factory. The observed results were: all catalog manifests valid; all five installed skill imports passed; the factory tarball contained its configured scripts and raw-create request. After merging main, a second check validated all 24 catalog entries and compared 9 generated bundles with their source files.For the core regression,
skills/github-issue-triage/scripts/worker.pywas absent before the revert. After the revert, installing that skill into a temporary directory supplied the worker and bundle helpers, andpython -c 'import worker'succeeded from its installedscripts/directory.Pytest was not run locally: it is absent from this environment, and installed uv 0.9.17 is below this repo's required version (>=0.9.25). CI ran
uv run --group test pytest tests/(1520 passed, 23 skipped) and the separate plugin test step (10 passed) on commit3337a38. No live automation was dispatched.Video/Screenshots
Not applicable: this changes skill/catalog content, not a UI. Installation and build results are described above.
Notes
plugins/bundle sources so the newly addedgithub-comment-cleanupautomation continues to work. This does not revert the automation service's plugin-spec API or the general guidance from PR docs: document plugin-spec automations #794.plugins/<name>paths from movingmaincould fail after deployment; pinned historical commits remain available. Review rollout impact before merge.skills/github/scripts/; npm's dry-run package list omitted these symlinks. Installation from the Git checkout passed, but npm-packaged standalone skills need verification.This PR description was created by an AI agent (OpenHands) on behalf of the user.