Skip to content

revert: restore standalone automation skills (OSS-14957) - #863

Merged
malhotra5 merged 2 commits into
mainfrom
revert/oss-14957-plugin-spec
Oct 29, 2026
Merged

malhotra5 merged 2 commits into
mainfrom
revert/oss-14957-plugin-spec

Conversation

@malhotra5

@malhotra5 malhotra5 commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

HUMAN:

Reverting changes as per the PR #812


AGENT:

Why

PR #812 removed task guidance and runtime scripts from 11 standalone automation skills. Installing github-issue-triage, for example, gave an agent a plugin-spec setup guide but no worker or helpers. Restore the standalone skills while we verify the intended packaging contract.

Summary

  • Revert PR feat: convert automation skills to plugins #812's skill-to-plugin migration, restoring automation scripts and task/setup guidance under skills/<name>/.
  • Restore skill-backed catalog bundles and the software factory's tarball flow, with their previous tests and generated catalog.
  • Preserve plugins/ bundle path support needed by the newer github-comment-cleanup automation on main, and keep its plugin-only installation tests. Remove one restored trailing whitespace character in the Slack channel monitor skill.

Issue Number

OSS-14957 - Revert plugin-spec transition due to skill breakage

Related historical GitHub issue: #815 (closed, ready-for-dev) tracked the migration in the original PR. This PR reverses that implementation; it does not claim to complete the issue's original acceptance criteria.

How to Test

From the extensions repo root, I ran:

npm run build:automations                  # passed with new github-comment-cleanup bundle
npm run build:skills                       # generated 73 skills; qa-changes and release-notes marketplace warnings
python scripts/sync_extensions.py --check  # passed; non-blocking coverage warnings for github-comment-cleanup and issue-duplicate-checker
git diff --cached --check                  # passed before merge commit

An inline Python check validated every automation catalog manifest against automations/catalog.schema.json, compared bundle sources to automations/bundle-index.js, installed and imported five standalone skills with openhands.sdk.skills.install_skill (github-issue-triage, github-issue-to-pr, github-pr-reviewer, github-agents-md-maintainer, github-repo-monitor), and built a triage tarball with the software factory. The observed results were: all catalog manifests valid; all five installed skill imports passed; the factory tarball contained its configured scripts and raw-create request. After merging main, a second check validated all 24 catalog entries and compared 9 generated bundles with their source files.

For the core regression, skills/github-issue-triage/scripts/worker.py was absent before the revert. After the revert, installing that skill into a temporary directory supplied the worker and bundle helpers, and python -c 'import worker' succeeded from its installed scripts/ directory.

Pytest was not run locally: it is absent from this environment, and installed uv 0.9.17 is below this repo's required version (>=0.9.25). CI ran uv run --group test pytest tests/ (1520 passed, 23 skipped) and the separate plugin test step (10 passed) on commit 3337a38. No live automation was dispatched.

Video/Screenshots

Not applicable: this changes skill/catalog content, not a UI. Installation and build results are described above.

Notes

  • This restores the 11 skills migrated by PR feat: convert automation skills to plugins #812. After merging current main, the catalog schema and builder still allow plugins/ bundle sources so the newly added github-comment-cleanup automation continues to work. This does not revert the automation service's plugin-spec API or the general guidance from PR docs: document plugin-spec automations #794.
  • Existing plugin-spec automations fetching removed plugins/<name> paths from moving main could fail after deployment; pinned historical commits remain available. Review rollout impact before merge.
  • Restored GitHub helper files are symlinks to skills/github/scripts/; npm's dry-run package list omitted these symlinks. Installation from the Git checkout passed, but npm-packaged standalone skills need verification.
  • The HUMAN section was filled in by a human and has not been edited by this agent. OSS-14957 remains the primary request; GitHub Convert automation skills to plugin-spec packages #815 is linked only as context for the reverted migration.

This PR description was created by an AI agent (OpenHands) on behalf of the user.

This reverts commit f79208b to restore standalone automation skills and their scripts.

Co-authored-by: openhands <openhands@all-hands.dev>
@malhotra5 malhotra5 changed the title Revert automation skill-to-plugin migration to restore standalone skills revert: restore standalone automation skills (OSS-14957) Oct 29, 2026
@github-actions github-actions Bot added the type: revert Reverts a previous commit label Oct 29, 2026
Preserve the newly added comment-cleanup plugin while retaining plugin bundle path support needed by its catalog entry.

Co-authored-by: openhands <openhands@all-hands.dev>
@malhotra5
malhotra5 marked this pull request as ready for review October 29, 2026 15:26

@all-hands-bot all-hands-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was posted by an AI agent (OpenHands).

Reviewed the revert at head 3337a38 against main, with the repository guidance in AGENTS.md applied. The change is squarely in this repository's scope (it owns the public registry of skills, plugins, and automation catalog bundles), so the review proceeded to the technical pass.

Verified in the workspace at this exact head:

  • uv run pytest tests/ — 1520 passed, 23 skipped, matching CI's run on this commit.
  • npm run build:automations — passes; regenerated bundle-index.js/catalog-index.js are byte-identical to the committed generated files, and all 9 generated bundles were verified byte-equal to their manifest files sources.
  • python scripts/sync_extensions.py --check — passes with only the same non-blocking coverage warnings that exist on main (plugins/github-comment-cleanup, plugins/issue-duplicate-checker), which are intentional per the PR description.
  • All 24 catalog manifests validate against automations/catalog.schema.json; every bundle source path referenced by the manifests exists (symlinks into skills/github/scripts/ resolve, and skills/github/ itself is untouched by this diff).
  • The core regression is real and fixed: skills/github-issue-triage/scripts/worker.py is absent on main and present after the revert. Installing the five standalone skills (github-issue-triage, github-issue-to-pr, github-pr-reviewer, github-agents-md-maintainer, github-repo-monitor) via openhands.sdk.skills.install_skill into a temp directory yields complete bundle files, and import worker succeeds from the installed scripts/ directory.
  • The end state of catalog.schema.json and scripts/build-automation-catalog.mjs is byte-identical to main, so plugins/ bundle sources remain valid for the newer github-comment-cleanup automation, whose plugin, tests, and marketplace entries are preserved unchanged. Head contains all of main (no commits behind).
  • No stale plugins/<name> setup references remain in the restored skill guides, and the slack-channel-monitor script carries no trailing whitespace, matching the PR notes.

The two intentional deviations from a pure revert (removed WORKSPACE_BASE re-set in test_automation_llm_provenance.py; empty __file__ in test_slack_channel_monitor.py) are covered by the passing suite and are not material. The rollout caveat for plugin-spec automations fetching removed plugins/<name> paths from moving main, and the npm-packaging caveat for symlinked helpers, are already disclosed in the PR notes for the maintainer to weigh; nothing further to add.

No material issues found.

✅ APPROVED

@malhotra5
malhotra5 merged commit 100fb5a into main Oct 29, 2026
22 of 23 checks passed
@malhotra5
malhotra5 deleted the revert/oss-14957-plugin-spec branch October 29, 2026 15:47
@openhands-release-bot

Copy link
Copy Markdown
Contributor

🚀 Released in v0.37.0.

@openhands-release-bot openhands-release-bot Bot added the released: v0.37.0 Shipped in v0.37.0 label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released: v0.37.0 Shipped in v0.37.0 type: revert Reverts a previous commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants