Add common historical border types #310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-border-type-986
branch
from
ef5c917 to
5a45542
Compare
1ec5
commented
Sep 23, 2025
| region: "Regional Boundary" | ||
| reichsgau: "Reichsgau Boundary" | ||
| republic: "Republican Boundary" | ||
| rode: "Rode Boundary" |
There was a problem hiding this comment.
I added this in response to a request on the forum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a number of entries to the shortlist of translatable
border_type=*values that appear in search results and query results. These additions draw from OpenHistoricalMap/nominatim-ui@more-places...jeffreyameyer:nominatim-ui:more-places and existing values ofborder_type=*andplace=*that follow the keyword naming conventions. Once this change lands, there should be much less reason to useplace=*for administrative areas that don’t correspond to populated places.Fixes OpenHistoricalMap/issues#986.