Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLMIS-8027: Changed modal prop to prevent inconsistency around the app #54

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

DominikNoga
Copy link
Contributor

For purposes of ticket: https://openlmis.atlassian.net/browse/OLMIS-7987. Modal prop children was changed to 'body' which caused inconsistency in the prop passing. And some modals which were using the old prop name were not displaying any content. Which caused the issue mentioned in ticket: https://openlmis.atlassian.net/browse/OLMIS-8027

Changed prop name back to 'children', because only one spot uses the 'body' name

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@DominikNoga DominikNoga merged commit 3d51280 into master Oct 24, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants