Update test_omp_target_offload.c #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 5.0 the value must be either DEFAULT, DISABLED or MANDATORY, hence any other value is an error.
spophale
added
bug fix
tob2
approved these changes
Jan 27, 2021
| OMPVV_WARNING_IF(policy==UNKNOWN,"OMP_TARGET_OFFLOAD has an unknown value"); | ||
| OMPVV_WARNING_IF(policy==NOTSET, "OMP_TARGET_OFFLOAD has not been set"); | ||
| OMPVV_ERROR_IF(policy==UNKNOWN,"OMP_TARGET_OFFLOAD has an unknown value"); | ||
| OMPVV_ERROR_IF(policy==NOTSET, "OMP_TARGET_OFFLOAD has not been set"); | ||
|
|
There was a problem hiding this comment.
Other values/unknown are outside of the spec, hence, giving an error is surely sensible. While notset is valid, testing for unset is besides the point for this testcase – hence, an error is also fine → LGTM.
(Requires manually setting the env var or something like PR #262 to avoid the error.)
jhdavis8
approved these changes
Feb 1, 2021
tmh97
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 5.0 the value must be either DEFAULT, DISABLED or MANDATORY, hence any other value is an error.