Skip to content

Update packaging #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DimitriPapadopoulos wants to merge 6 commits into
base: main
Choose a base branch
from
+12 −9
Open

Update packaging #137

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6c09097
PEP 639 compliance
DimitriPapadopoulos Jan 16, 2026
2718ac4
Update pyproject.toml
DimitriPapadopoulos Jan 16, 2026
0cadce3
Update Python versions in Trove classifiers
DimitriPapadopoulos Jan 16, 2026
5298303
Ooops...
DimitriPapadopoulos Jan 16, 2026
0739358
Fix authors
DimitriPapadopoulos Jan 16, 2026
4dbf3ce
Python 3.13 not supported yet
DimitriPapadopoulos Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,33 @@
[build-system]
requires = ["flit_core >=3.2,<4"]
requires = ["flit_core >=3.12,<4"]
build-backend = "flit_core.buildapi"

[project]
name = "pyopenms_viz"
module = "pyopenms_viz"
dist-name = "pyopenms_viz"
author = "OpenMS Team"
authors = [
{name = "OpenMS Team", email = "[email protected]"},
{name = "Joshua Charkow", email = "[email protected]"},
]
version = "1.0.0"
author-email = "[email protected]"
home-page = "https://github.com/OpenMS/pyopenms_viz/"
description = "A package for visualizing mass spectrometry data using pandas dataframes"
readme = "README.md"
readme-content-type = "text/markdown"
classifiers = [
"Intended Audience :: Science/Research",
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'License :: OSI Approved :: BSD License' classifier was removed but not replaced with a more specific classifier. Consider adding 'License :: OSI Approved :: BSD License' back to the classifiers list to maintain discoverability on PyPI, as classifiers serve a different purpose than the license field.

Suggested change
"Intended Audience :: Science/Research",
"Intended Audience :: Science/Research",
"License :: OSI Approved :: BSD License",

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your suggestion is not compliant with current Python packaging standards and PyPi is perfectly aware of the license field.

And where does "classifiers serve a different purpose than the license field" come from? Please provide links to authoritative documentation.

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyPI moved to license in 2024:
pypi/warehouse#16620 (comment)

"License :: OSI Approved :: BSD License",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Topic :: Scientific/Engineering :: Bio-Informatics",
"Topic :: Scientific/Engineering :: Chemistry",
]
requires-python = ">=3.10, <=3.13"
license = "BSD-3-Clause"
license-files = ["LICENSE"]
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license-files field is redundant when using the SPDX license identifier format. When license is specified as a string (SPDX identifier), the license-files field is not needed according to PEP 621. Either use license = {text = \"BSD-3-Clause\"} with license-files, or use just license = \"BSD-3-Clause\" without license-files.

Suggested change
license-files = ["LICENSE"]

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this come from? It's a bad idea and it's not compliant with PEP 639.

See "Use a default value for license-files if not specified" in Appendix: Rejected Ideas of PEP 639.

requires-python = ">=3.10, <3.13"
dependencies = ["pandas>=0.17"]

[project.urls]
Homepage = "https://github.com/OpenMS/pyopenms_viz/"

[project.optional-dependencies]
testing = ["pytest", "syrupy"]
all = ["bokeh>=3.4.1", "plotly", "matplotlib"]
Expand Down
Loading