Replace php date functios with carbon

[sreichel]

Description (*)

Use rector to replace native date functions with carbon,

• see https://carbon.nesbot.com/docs/

(prepare to replace Zend_Date)

Related Pull Requests

• see rector: Replace php date functions, Varien_Date with Carbon date library #4463

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Copilot reviewed 102 out of 102 changed files in this pull request and generated 11 comments.

Comments suppressed due to low confidence (1)

app/code/core/Mage/Index/Model/Observer.php:154

• Using Carbon::now()->sub() mutates the Carbon instance. This could cause issues if the $now variable is reused later. Consider using Carbon::now()->subSeconds(self::OLD_INDEX_EVENT_THRESHOLD_SECONDS) or calling copy() first to avoid mutation: $now->copy()->sub($dateInterval).