Remove InMemoryPlatformConnection and migrate tests to mock drive service#133
Merged
koenvanderveen merged 2 commits intomainfrom Feb 17, 2026
Merged
Remove InMemoryPlatformConnection and migrate tests to mock drive service#133koenvanderveen merged 2 commits intomainfrom
koenvanderveen merged 2 commits intomainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…vice - Migrate test_checkpoints.py and test_rolling_state.py from _pair_with_in_memory_connection to pair_with_mock_drive_service_connection - Delete inmemory_connection.py (684 lines) and deprecated main.ipynb - Remove _pair_with_in_memory_connection factory method from SyftboxManager - Rename base_config_for_in_memory_connection to _base_config_for_testing - Simplify _add_connection guard to only allow MockDriveService connections 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
koenvanderveen
force-pushed
the
koen/remove-inmemory-connection
branch
from
17db941 to
0286781
Compare
…ove-inmemory-connection # Conflicts: # syft_client/sync/connections/inmemory_connection.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_checkpoints.pyandtest_rolling_state.pyfrom_pair_with_in_memory_connectiontopair_with_mock_drive_service_connectioninmemory_connection.py(684 lines) and deprecatedmain.ipynbnotebook_pair_with_in_memory_connectionfactory method andInMemoryPlatformConnectionimport fromSyftboxManagerbase_config_for_in_memory_connection→_base_config_for_testing(still used by mock drive service setup)_add_connectionguard to only allowMockDriveServiceconnectionsTest plan
just test-unit)InMemoryPlatformConnectionin codebase🤖 Generated with Claude Code