Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profiles #29

Draft
wants to merge 61 commits into
base: develop
Choose a base branch
from
Draft

User profiles #29

wants to merge 61 commits into from

Conversation

tomast1337
Copy link
Member

@tomast1337 tomast1337 commented Jan 12, 2025

This PR adds comprehensive features to enhance user profile management and songs and user search functionality

Planned Features:

  • Song search functionality based on keywords

  • User profile search functionality based on keywords

  • User profile pages for viewing member information

  • Profile editing interface for users to manage their details

Nice examples of profiles

Useful links about text search in MongoDB:

@tomast1337 tomast1337 self-assigned this Jan 12, 2025
@tomast1337
Copy link
Member Author

tomast1337 commented Jan 15, 2025

@Bentroen
For the user search feature, I created this search box, I assume the same search box can be repurposed for a song search feature, Does this approach seem suitable?

search

@tomast1337 tomast1337 added the help wanted Extra attention is needed label Jan 21, 2025
@tomast1337
Copy link
Member Author

@Bentroen To implement a search feature for users and songs is harder than I imagined.

I have a few worries about How efficient searching by keyword, name, title, author, and description by section or substring can be. And, how could we avoid full reads in case some user requests?

@tomast1337 tomast1337 changed the title Feat (profiles): Implement user-profiles and search functionality [WIP] Feat (profiles): Implement user-profiles and user and song search [WIP] Jan 21, 2025
@tomast1337
Copy link
Member Author

https://www.mongodb.com/resources/basics/full-text-search

I guess this is the approach to be taken with MongoDB, it already take care of all of this like fuzzy search and indexing is bazeds on words and not full strings.

@Bentroen
Copy link
Member

Bentroen commented Mar 3, 2025

Thanks for working on these features!

@Bentroen For the user search feature, I created this search box, I assume the same search box can be repurposed for a song search feature, Does this approach seem suitable?

Yes, we can have a single search feature that can return results for both users and channels - selectable with a tab widget, similar to what YouTube does.
For simplicity, and since song search would be more useful than searching for users at first, we could implement search only for songs, and leave user search for a later stage.
(It seems like searching for channel is not very common compared to video search, so even YT relegated this option to a separate popup):

I have a few worries about How efficient searching by keyword, name, title, author, and description by section or substring can be. And, how could we avoid full reads in case some user requests?

Since user profiles are such a simple feature compared to search, I believe this PR can be reduced in scope to just user profiles, since they don't rely on search being ready to be merged into production. We can leverage the existing search infrastructure implemented here in a subsequent PR.

@Bentroen Bentroen changed the title User profiles; user and song search [WIP] User profiles Mar 3, 2025
Bentroen and others added 24 commits March 5, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants