Skip to content

[WIP] Source Word Features in Translation #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[WIP] Source Word Features in Translation #1564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ca8672
Feature: addition of source word features
vikrant97 Sep 16, 2019
18d56bc
Update opts.py
vikrant97 Sep 16, 2019
b407ecd
Update embeddings.py
vikrant97 Sep 16, 2019
92f589c
Update embeddings.py
vikrant97 Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions onmt/modules/embeddings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,11 @@ def __init__(self, word_vec_size,
# (these have no effect if feat_vocab_sizes is empty)
if feat_merge == 'sum':
feat_dims = [word_vec_size] * len(feat_vocab_sizes)
elif feat_vec_size > 0:
feat_dims = [feat_vec_size] * len(feat_vocab_sizes)
elif len(feat_vec_size) != 0:
if len(feat_vocab_sizes) == 0:
feat_dims = []
else:
feat_dims = feat_vec_size
else:
feat_dims = [int(vocab ** feat_vec_exponent)
for vocab in feat_vocab_sizes]
Expand Down Expand Up @@ -209,10 +212,10 @@ def _validate_args(self, feat_merge, feat_vocab_sizes, feat_vec_exponent,
if feat_vec_exponent != 0.7:
warnings.warn("Merging with sum, but got non-default "
"feat_vec_exponent. It will be unused.")
if feat_vec_size != -1:
if len(feat_vec_size) != 0:
warnings.warn("Merging with sum, but got non-default "
"feat_vec_size. It will be unused.")
elif feat_vec_size > 0:
elif len(feat_vec_size) != 0:
# features will use feat_vec_size
if feat_vec_exponent != -1:
warnings.warn("Not merging with sum and positive "
Expand Down
3 changes: 2 additions & 1 deletion onmt/opts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ def model_opts(parser):
choices=['concat', 'sum', 'mlp'],
help="Merge action for incorporating features embeddings. "
"Options [concat|sum|mlp].")
group.add('--feat_vec_size', '-feat_vec_size', type=int, default=-1,
group.add('--feat_vec_size', '-feat_vec_size', type=int,
default=[], nargs='*',
help="If specified, feature embedding sizes "
"will be set to this. Otherwise, feat_vec_exponent "
"will be used.")
Expand Down