Skip to content

feat: update bigsky module initialization #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rroutsong
Copy link
Collaborator

Update to reflect the new lua module load infrastructure of bigsky.

@rroutsong rroutsong self-assigned this Apr 10, 2025
Copy link
Collaborator

@ewalt98 ewalt98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like several other lines need updating in config.py: line 134 and line 173. Both refer to the /gs1/ dir structure of the old BigSky.

Would line 172 in utils.py need to be updated as well to load the correct version of snakemake?

@rroutsong
Copy link
Collaborator Author

Looks like several other lines need updating in config.py: line 134 and line 173. Both refer to the /gs1/ dir structure of the old BigSky.

Line 134 is related to the previous finding logic we had for weave, whereby you could enter a run identifier and it would pick it up in the directory. Do you have a new landing directory for RML on bigsky?

Same for line 173

Would line 172 in utils.py need to be updated as well to load the correct version of snakemake?

Line 172 is the correct version of snakemake, the profiles bit needs a little more work to be compatible with snakemake 8+, if possible.

@ewalt98
Copy link
Collaborator

ewalt98 commented Apr 14, 2025

Line 134 is related to the previous finding logic we had for weave, whereby you could enter a run identifier and it would pick it up in the directory. Do you have a new landing directory for RML on bigsky?

Same for line 173

The new directory structure is /data/rml_ngs/SequencerRuns/

Copy link
Member

@skchronicles skchronicles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this for the BigSky changes. It looks great!

The only other thing I would update is the install documentation. It appears to be out of date.

Here is the path to the file.

docs/install.md

The section for BigSky still refers to the /gs1 filesystem and references spack.

@skchronicles
Copy link
Member

You may want to test this out but here is a file that could be used to add deps to the users path:

/data/openomics/bin/source_weave.sh

@rroutsong
Copy link
Collaborator Author

You may want to test this out but here is a file that could be used to add deps to the users path:

/data/openomics/bin/source_weave.sh

this is already up to date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants