-
Notifications
You must be signed in to change notification settings - Fork 17
35 investigate migrating to meson [WIP] #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
35 investigate migrating to meson [WIP] #44
Conversation
Updated via cell phone to see if this change fixes some problems.
More updated version of pocketfft.
Changed via cellphone to see if this can fix Windows pocketfft compile issue.
…m/ErichZimmer/openpiv-c--qt into 35-investigate-migrating-to-meson
README.md
Outdated
`cmake -DCMAKE_BUILD_TYPE=RelWithDebugInfo -B build -S .`. | ||
To get binaries: | ||
* `meson install -C builddir` if the prefix was set or | ||
* `meson install -C buildfir --destdir <some directory>` to install in a specifit directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/specifit/specific/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That typo is fixed. Apparently, I overlooked it when checking for grammatical errors.
|
||
* build | ||
* test -> *_test | ||
Make sure the prefix, or destdir, is set so binaries are not accidentally installed on the system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would hope for unix-like environment permissions would prevent installation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be an issue for Unix. However, Windows is where that warning was primarily targeted for. If not set, Meson defaults to C:/ (or whatever letter the current drive is assigned) which could may cause issues and cluttering of the drive. I can be more explicit on that topic if needed.
|
||
pkgconfig = import('pkgconfig') | ||
|
||
pkgconfig.generate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way this information can be taken from the project object rather than repeating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the redundant information through meson project defines.
NOTICE:
This pull request commits significant changes to the project. As such, it is important to review all changes cerefully.
Preface
The Meson build system offers a concise and effect way to compile applications and libraries. As it is a newer build system using modern Python, it avoids some pitfalls associated with CMake. Additionally, it offers native cross-compilation through the use of cross-compilation build files.
New:
subprojects
folder contains most external dependenciesChanges:
test
directory was renamed totests
Work in Progress