-
Notifications
You must be signed in to change notification settings - Fork 367
feat(model): Implement safe model deletion with trash functionality #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(model): Implement safe model deletion with trash functionality #283
Conversation
Good Catches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! How does this apply to the model.delete_checkpoints
method? I can imagine a backup of old checkpoints that isn't automatically synced to s3 being useful.
f0d7cec
to
2335282
Compare
That's a great question, You're right, the current implementation of the trash feature is focused on I think applying a similar "trash" concept to checkpoints is an excellent |
This pull request introduces a new "trash" feature to the ART framework,
providing a safety net for model deletion. Previously, deleting a model was
a destructive and irreversible operation. Now, models are moved to a .trash
directory, allowing for recovery or permanent deletion at a later time.
This PR includes the following changes:
models to a .trash directory instead of permanently deleting them.
manage the trash:
src/art/cli.py with the following commands:
This feature significantly improves the safety and usability of the ART
framework by preventing accidental data loss.